Skip to content

AsSplitTopGraph fix wrong handle with same point #2114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mariusheine merged 2 commits into from
Jan 12, 2026
Merged

AsSplitTopGraph fix wrong handle with same point #2114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f89b119
AsplitTopGraph fix wrong handle with same point
TruongQuangSB Jan 7, 2026
84aa1db
fix path weight = 0
TruongQuangSB Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...se.set.application/src/org/eclipse/set/application/graph/TopologicalGraphServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,10 @@ public Optional<BigDecimal> findShortestDistanceInDirection(
@Override
public Optional<TopPath> findShortestPath(final TopPoint from,
final TopPoint to) {
if (from.equalLocation(to)) {
return Optional.of(
new TopPath(List.of(from.edge()), BigDecimal.ZERO, from));
}
final MultiContainer_AttributeGroup container = getContainer(
from.edge());
final PlanPro_Schnittstelle planProSchnittstelle = getPlanProSchnittstelle(
Expand Down
25 changes: 25 additions & 0 deletions java/bundles/org.eclipse.set.utils/src/org/eclipse/set/utils/graph/AsSplitTopGraph.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,11 @@ public Node splitGraphAt(final TopPoint at) {
* @return a node at the point where the graph was split
*/
public Node splitGraphAt(final TopPoint at, final Boolean inTopDirection) {
// When already split at the point
final Optional<Node> existedNode = existedSplitNodeAt(at);
if (existedNode.isPresent()) {
return existedNode.get();
}
final TOP_Kante edge = at.edge();
final List<Edge> pointEdgeList = pointEdgeGraph.edgeSet()
.stream()
Expand Down Expand Up @@ -211,6 +216,26 @@ public Node splitGraphAt(final TopPoint at, final Boolean inTopDirection) {
"Cannot split graph on a point outside the graph"); //$NON-NLS-1$
}

private Optional<Node> existedSplitNodeAt(final TopPoint at) {
if (isTopKnoten(at)) {
final TOP_Knoten atKnote = at.distance()
.compareTo(BigDecimal.ZERO) == 0
? at.edge().getIDTOPKnotenA().getValue()
: at.edge().getIDTOPKnotenB().getValue();
return pointEdgeGraph.vertexSet()
.stream()
.filter(n -> n.node != null)
.filter(n -> n.node == atKnote)
.findFirst();
}
return pointEdgeGraph.vertexSet()
.stream()
.filter(n -> n.point != null)
.filter(n -> n.point.edge() == at.edge()
&& n.point.distance().compareTo(at.distance()) == 0)
.findFirst();
}

private static boolean isTopKnoten(final TopPoint point) {
return point.distance().compareTo(BigDecimal.ZERO) == 0
|| point.distance()
Expand Down
Loading