-
Notifications
You must be signed in to change notification settings - Fork 10
log: add QNX x86_64 config support #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
log: add QNX x86_64 config support #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for the QNX x86_64 platform configuration to the FFI bridge between Rust and C++ in the logging module. The change ensures that the memory layout of SlotHandleStorage is properly defined and validated for this new platform.
Changes:
- Added
x86_64_qnxfeature support alongside existingx86_64_linuxandarm64_qnxconfigurations - Added compile-time error check to ensure only known configurations are used
- Updated build configuration to define the new platform target
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| score/mw/log/rust/score_log_bridge/src/ffi.rs | Added x86_64_qnx feature to struct definition and compile-time configuration validation |
| score/mw/log/rust/score_log_bridge/src/adapter.cpp | Added x86_64_qnx preprocessor condition to platform-specific assertions |
| score/mw/log/rust/score_log_bridge/BUILD | Added x86_64-qnx config_setting and applied it to both C++ defines and Rust crate features |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
- New platforms must be explicitly added to FFI. - Fix unallocated array - unrelated to log, prevents build.
bbe9f7b to
d93531f
Compare
Notes for Reviewer
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #