Skip to content

Conversation

@arkjedrz
Copy link
Contributor

@arkjedrz arkjedrz commented Jan 29, 2026

  • New platforms must be explicitly added to FFI.
  • Fix unallocated array - unrelated to log, prevents build.

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • PR title is short, expressive and meaningful
  • Commits are properly organized
  • Relevant issues are linked in the References section
  • Tests are conducted
  • Unit tests are added

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #

@arkjedrz arkjedrz requested a review from pawelrutkaq as a code owner January 29, 2026 09:28
@arkjedrz arkjedrz self-assigned this Jan 29, 2026
@arkjedrz arkjedrz temporarily deployed to workflow-approval January 29, 2026 09:28 — with GitHub Actions Inactive
@arkjedrz arkjedrz requested a review from Copilot January 29, 2026 09:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the QNX x86_64 platform configuration to the FFI bridge between Rust and C++ in the logging module. The change ensures that the memory layout of SlotHandleStorage is properly defined and validated for this new platform.

Changes:

  • Added x86_64_qnx feature support alongside existing x86_64_linux and arm64_qnx configurations
  • Added compile-time error check to ensure only known configurations are used
  • Updated build configuration to define the new platform target

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
score/mw/log/rust/score_log_bridge/src/ffi.rs Added x86_64_qnx feature to struct definition and compile-time configuration validation
score/mw/log/rust/score_log_bridge/src/adapter.cpp Added x86_64_qnx preprocessor condition to platform-specific assertions
score/mw/log/rust/score_log_bridge/BUILD Added x86_64-qnx config_setting and applied it to both C++ defines and Rust crate features

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Jan 29, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
2026/01/29 10:54:37 Downloading https://releases.bazel.build/8.3.0/release/bazel-8.3.0-linux-x86_64...
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: a1370657-deab-4d49-972d-49d8484af435
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.5.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.7.1, but got bazel_skylib@1.8.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.2.8 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.0.3, but got aspect_rules_lint@1.10.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version buildifier_prebuilt@7.3.1, but got buildifier_prebuilt@8.2.0.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.17.0.bcr.1, but got googletest@1.17.0.bcr.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
Loading: 4 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 17.415s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

- New platforms must be explicitly added to FFI.
- Fix unallocated array - unrelated to log, prevents build.
@arkjedrz arkjedrz force-pushed the arkjedrz_log-add-x86-64-qnx-support branch from bbe9f7b to d93531f Compare January 29, 2026 10:54
@arkjedrz arkjedrz requested a review from antonkri as a code owner January 29, 2026 10:54
@arkjedrz arkjedrz temporarily deployed to workflow-approval January 29, 2026 10:54 — with GitHub Actions Inactive
@arkjedrz arkjedrz deployed to workflow-approval January 29, 2026 10:54 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants