Add C++ coverage configuration and workflow #46

RSingh1511 · 2026-01-28T03:21:23Z

Add coverage_report.yml with LCOV/HTML report generation
Configure Bazel coverage flags in .bazelrc

Notes for Reviewer

Pre-Review Checklist for the PR Author

PR title is short, expressive and meaningful
Commits are properly organized
Relevant issues are linked in the References section
Tests are conducted
Unit tests are added

Checklist for the PR Reviewer

Commits are properly organized and messages are according to the guideline
Unit tests have been written for new behavior
Public API is documented
PR title describes the changes

Post-review Checklist for the PR Author

All open points are addressed and tracked via issues

References

Closes #

- Add coverage_report.yml with LCOV/HTML report generation - Configure Bazel coverage flags in .bazelrc

github-actions · 2026-01-28T03:22:03Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
2026/01/29 08:42:34 Downloading https://releases.bazel.build/8.3.0/release/bazel-8.3.0-linux-x86_64...
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: f3db37e7-4de8-4e9f-ae06-7365d50eecbd
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-eQOopREOYCL5vtTb6c1cwZrql4GVrJ1FqgxarQRe1xs="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.5.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.7.1, but got bazel_skylib@1.8.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.2.14 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.0.3, but got aspect_rules_lint@1.10.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version buildifier_prebuilt@7.3.1, but got buildifier_prebuilt@8.2.0.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.17.0.bcr.1, but got googletest@1.17.0.bcr.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 17.749s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

github-actions · 2026-01-28T03:24:15Z

The created documentation from the pull request is available at: docu-html

- LLVM flags (-mllvm, -runtime-counter-relocation) are incompatible with GCC - Comment them out to fix CI coverage build failures - Can be uncommented when using LLVM/Clang toolchain

Remove LLVM-specific flags and instrumentation filter that were causing empty coverage reports. Use only the three baselibs flags: - coverage --features=coverage - coverage --combined_report=lcov - coverage --cache_test_results=no Fixes: SWP-240231

- Add --ignore-errors empty to genhtml to handle sparse coverage

- Add file size check before running genhtml - Add more ignore-errors flags

PiotrKorkus

It looks like you took some of the settings from baselibs but baselibs uses different toolchain.
Please double check which gcc toolchain is correct.
Coverage data should never be empty.
Also Rust and C++ coverages should be calculated separately.

PiotrKorkus · 2026-01-28T10:34:10Z

.github/workflows/coverage_report.yml

+          else
+            echo "Coverage report is empty, skipping HTML generation"
+            mkdir -p cpp_coverage
+            echo "<html><body><h1>No coverage data available</h1></body></html>" > cpp_coverage/index.html
+          fi


it should never be empty. Empty = expected fail

RSingh1511 · 2026-01-29T08:46:21Z

It looks like you took some of the settings from baselibs but baselibs uses different toolchain. Please double check which gcc toolchain is correct. Coverage data should never be empty. Also Rust and C++ coverages should be calculated separately.

Thanks for pointing this out! I’ve added score_bazel_cpp_toolchains (the same toolchain used in baselibs), which properly supports Bazel coverage. Coverage data is now generated correctly and is no longer empty

PiotrKorkus · 2026-01-29T08:58:16Z

.github/workflows/coverage_report.yml

+
+      - name: Run Bazel Coverage
+        run: |
+          bazel coverage --config=blcov-x86_64-linux -- //score/... //tests/...


why run //tests/... when you have instrumentation filter on //score?

PiotrKorkus · 2026-01-29T08:59:15Z

.bazelrc

+coverage --instrumentation_filter="^//score[/:]"
+
+# Coverage configuration
+build:blcov-x86_64-linux --incompatible_strict_action_env


bl stands for baselibs

PiotrKorkus · 2026-01-29T09:04:50Z

.github/workflows/coverage_report.yml

+          sudo apt-get install -y lcov
+      - name: Setup Bazel


please use consistent new line formatting

PiotrKorkus · 2026-01-29T09:12:03Z

MODULE.bazel

+gcc_cpp = use_extension("@score_bazel_cpp_toolchains//extensions:gcc.bzl", "gcc", dev_dependency = True)
+gcc_cpp.toolchain(
+    name = "score_gcc_x86_64_toolchain",
+    target_cpu = "x86_64",
+    target_os = "linux",
+    use_default_package = True,
+    version = "12.2.0",
+)
+use_repo(gcc_cpp, "score_gcc_x86_64_toolchain")
+
 gcc = use_extension("@score_toolchains_gcc//extentions:gcc.bzl", "gcc", dev_dependency = True)
 gcc.toolchain(
    sha256 = "457f5f20f57528033cb840d708b507050d711ae93e009388847e113b11bf3600",
    strip_prefix = "x86_64-unknown-linux-gnu",
    url = "https://github.com/eclipse-score/toolchains_gcc_packages/releases/download/0.0.1/x86_64-unknown-linux-gnu_gcc12.tar.gz",
 )
+use_repo(gcc, "gcc_toolchain", "gcc_toolchain_gcc")


I think those 2 shouldn't coexist or only one common config should be used for build, test and coverage for x86 linux

4og · 2026-01-29T09:35:09Z

MODULE.bazel

 bazel_dep(name = "score_platform", version = "0.5.1", dev_dependency = True)  # This is main score repo

 # Toolchains and extensions
+bazel_dep(name = "score_bazel_cpp_toolchains", version = "0.2.0", dev_dependency = True)


If you use this, you should kick out score_toolchains_gcc and score_toolchains_qnx.
I suggest to do it in a separate PR and do not mix up with the coverage workflow.

4og · 2026-01-29T09:40:39Z

.github/workflows/coverage_report.yml

+# SPDX-License-Identifier: Apache-2.0
+# *******************************************************************************
+
+name: Code Coverage


It's a copy-paste from baselibs. I'm actually considering to have it reusable via cicd_workflows, but I'm not sure this workflow is in the right shape to push it there.

Ideally, if it's to be reusable, it should support not only C++, but also Rust and maybe Python.
And for Rust, I'm wondering how it will mix up with the Ferrocene toolchain. @pawelrutkaq, does the rust coverage also rely on bazel coverage?

Add C++ coverage configuration and workflow

9904755

- Add coverage_report.yml with LCOV/HTML report generation - Configure Bazel coverage flags in .bazelrc

RSingh1511 requested review from antonkri, arsibo and pawelrutkaq as code owners January 28, 2026 03:21

RSingh1511 temporarily deployed to workflow-approval January 28, 2026 03:21 — with GitHub Actions Inactive

Fixing copyright issues in coverage report

e08aa69

RSingh1511 temporarily deployed to workflow-approval January 28, 2026 04:26 — with GitHub Actions Inactive

Comment out LLVM-specific coverage flags for GCC compatibility

f260808

- LLVM flags (-mllvm, -runtime-counter-relocation) are incompatible with GCC - Comment them out to fix CI coverage build failures - Can be uncommented when using LLVM/Clang toolchain

RSingh1511 temporarily deployed to workflow-approval January 28, 2026 05:31 — with GitHub Actions Inactive

Merge branch 'main' into rs/swp-240231

d99f76c

RSingh1511 temporarily deployed to workflow-approval January 28, 2026 06:42 — with GitHub Actions Inactive

Comment out LLVM-specific coverage flags for GCC compatibility

29c4fb1

- LLVM flags (-mllvm, -runtime-counter-relocation) are incompatible with GCC - Comment them out to fix CI coverage build failures - Can be uncommented when using LLVM/Clang toolchain

RSingh1511 temporarily deployed to workflow-approval January 28, 2026 06:59 — with GitHub Actions Inactive

RSingh1511 temporarily deployed to workflow-approval January 28, 2026 08:13 — with GitHub Actions Inactive

Fix coverage configuration issue

10dcabb

Remove LLVM-specific flags and instrumentation filter that were causing empty coverage reports. Use only the three baselibs flags: - coverage --features=coverage - coverage --combined_report=lcov - coverage --cache_test_results=no Fixes: SWP-240231

RSingh1511 force-pushed the rs/swp-240231 branch from 8449a01 to 10dcabb Compare January 28, 2026 08:15

RSingh1511 temporarily deployed to workflow-approval January 28, 2026 08:15 — with GitHub Actions Inactive

Add ignore-errors flag and instrumentation filter for coverage

8fab87b

- Add --ignore-errors empty to genhtml to handle sparse coverage

RSingh1511 temporarily deployed to workflow-approval January 28, 2026 08:42 — with GitHub Actions Inactive

Make coverage report generation more resilient

8ef9469

- Add file size check before running genhtml - Add more ignore-errors flags

RSingh1511 temporarily deployed to workflow-approval January 28, 2026 08:58 — with GitHub Actions Inactive

Fix comment in coverage configuration

fc1fa92

RSingh1511 temporarily deployed to workflow-approval January 28, 2026 09:24 — with GitHub Actions Inactive

PiotrKorkus requested changes Jan 28, 2026

View reviewed changes

Remove placeholder logic - empty coverage should fail

dfe07a9

RSingh1511 had a problem deploying to workflow-approval January 28, 2026 12:49 — with GitHub Actions Failure

RSingh1511 temporarily deployed to workflow-approval January 29, 2026 04:36 — with GitHub Actions Inactive

RSingh1511 had a problem deploying to workflow-approval January 29, 2026 04:36 — with GitHub Actions Failure

Fix coverage measurement using score_bazel_cpp_toolchains

34bbd76

RSingh1511 force-pushed the rs/swp-240231 branch from bd555b3 to 34bbd76 Compare January 29, 2026 08:42

RSingh1511 had a problem deploying to workflow-approval January 29, 2026 08:42 — with GitHub Actions Failure

PiotrKorkus reviewed Jan 29, 2026

View reviewed changes

4og requested changes Jan 29, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add C++ coverage configuration and workflow #46

Add C++ coverage configuration and workflow #46

Uh oh!

RSingh1511 commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

PiotrKorkus left a comment

Uh oh!

PiotrKorkus Jan 28, 2026

Uh oh!

RSingh1511 Jan 28, 2026

Uh oh!

RSingh1511 commented Jan 29, 2026

Uh oh!

PiotrKorkus Jan 29, 2026

Uh oh!

PiotrKorkus Jan 29, 2026

Uh oh!

PiotrKorkus Jan 29, 2026

Uh oh!

PiotrKorkus Jan 29, 2026

Uh oh!

4og Jan 29, 2026

Uh oh!

4og Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add C++ coverage configuration and workflow #46

Are you sure you want to change the base?

Add C++ coverage configuration and workflow #46

Uh oh!

Conversation

RSingh1511 commented Jan 28, 2026

Notes for Reviewer

Pre-Review Checklist for the PR Author

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

References

Uh oh!

github-actions bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

PiotrKorkus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RSingh1511 commented Jan 29, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Jan 28, 2026 •

edited

Loading