-
Notifications
You must be signed in to change notification settings - Fork 21
Use score::mw::log #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MaciejKaszynski
wants to merge
8
commits into
eclipse-score:main
Choose a base branch
from
etas-contrib:log-internal-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use score::mw::log #191
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ed60bac
Adding id hash <<operator
MaciejKaszynski e28ceab
Adding bazel cout flag
MaciejKaszynski 5c16b94
Fixing test
MaciejKaszynski 84f1325
Fixing formatting
MaciejKaszynski 96e8aa1
Fixing build error
MaciejKaszynski 13275b8
Enabling core dumps for started processes
MaciejKaszynski b373c10
Adding a fixture to auto download core dumps
MaciejKaszynski 062601d
Fixing dumps for QNX
MaciejKaszynski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,16 +15,13 @@ | |
| #define IDENTIFIER_HASH_H_ | ||
|
|
||
| #include <cstddef> | ||
| #include <optional> | ||
| #include <ostream> | ||
| #include <sstream> | ||
| #include <string> | ||
| #include <string_view> | ||
| #include <unordered_map> | ||
|
|
||
| namespace score | ||
| { | ||
|
|
||
| namespace lcm | ||
| namespace score::lcm | ||
| { | ||
|
|
||
| /// @file identifier_hash.hpp | ||
|
|
@@ -145,7 +142,7 @@ class IdentifierHash final | |
| /// @param os The output stream. | ||
| /// @param id The IdentifierHash object to output. | ||
| /// @return A reference to the output stream. | ||
| inline std::ostream& operator<<(std::ostream& os, const IdentifierHash& id) | ||
| inline std::ostream& operator<<(std::ostream& os, const IdentifierHash& id) noexcept | ||
| { | ||
| const auto& reg = IdentifierHash::get_registry(); | ||
| const auto it = reg.find(id.data()); | ||
|
|
@@ -160,8 +157,31 @@ inline std::ostream& operator<<(std::ostream& os, const IdentifierHash& id) | |
| return os; | ||
| } | ||
|
|
||
| } // namespace lcm | ||
| } // namespace score::lcm | ||
|
|
||
| #if __has_include("score/mw/log/logger.h") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To toggle between std::cout logging and mw::log should be only controlled with bazel build options |
||
| #include "score/mw/log/logger.h" | ||
|
|
||
| namespace score::lcm | ||
| { | ||
|
|
||
| inline score::mw::log::LogStream& operator<<(score::mw::log::LogStream& log_stream, const IdentifierHash& id) noexcept | ||
| { | ||
| const auto& reg = IdentifierHash::get_registry(); | ||
| const auto it = reg.find(id.data()); | ||
| if (it != reg.end()) | ||
| { | ||
| log_stream << it->second; | ||
| } | ||
| else | ||
| { | ||
| log_stream << "<Unknown IdentifierHash: " << id.data() << ">"; | ||
| } | ||
| return log_stream; | ||
| } | ||
|
|
||
| } // namespace score::lcm | ||
|
|
||
| } // namespace score | ||
| #endif | ||
|
|
||
| #endif // IDENTIFIER_HASH_H_ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the noexcept correct?