Skip to content

Fix no comms reporting crash#188

Open
WilliamRoebuck wants to merge 14 commits intoeclipse-score:mainfrom
etas-contrib:feature/no-comms-reporting-crash
Open

Fix no comms reporting crash#188
WilliamRoebuck wants to merge 14 commits intoeclipse-score:mainfrom
etas-contrib:feature/no-comms-reporting-crash

Conversation

@WilliamRoebuck
Copy link
Copy Markdown
Contributor

Add test for and fix a case where opening shared memory before attempting to report running from a non-reporting process would cause a crash.
Some formatting changes have been made but are separated into their own commits

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: a8a44fc5-ed44-4a95-9f21-9244c2e396c4
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (34 packages loaded, 10 targets configured)

Analyzing: target //:license-check (85 packages loaded, 10 targets configured)

Analyzing: target //:license-check (136 packages loaded, 2463 targets configured)

Analyzing: target //:license-check (149 packages loaded, 5380 targets configured)

Analyzing: target //:license-check (154 packages loaded, 5429 targets configured)

Analyzing: target //:license-check (156 packages loaded, 7818 targets configured)

Analyzing: target //:license-check (161 packages loaded, 10106 targets configured)

INFO: Analyzed target //:license-check (162 packages loaded, 10232 targets configured).
[5 / 16] Creating runfiles tree bazel-out/k8-fastbuild/bin/license.check.license_check.runfiles; 0s local ... (2 actions, 1 running)
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 21.180s, Critical Path: 2.36s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

The created documentation from the pull request is available at: docu-html

@WilliamRoebuck WilliamRoebuck force-pushed the feature/no-comms-reporting-crash branch from bf86f35 to 3e87606 Compare May 1, 2026 08:06
Comment thread tests/integration/incorrect_config_no_comms/control_client_mock.cpp Outdated
Comment thread tests/integration/incorrect_config_no_comms/test_incorrect_config_no_comms.py Outdated
Comment thread tests/integration/incorrect_config_non_reporting/BUILD
Comment thread src/control_client_lib/src/control_client_impl.cpp Outdated
@WilliamRoebuck WilliamRoebuck force-pushed the feature/no-comms-reporting-crash branch from 3415e74 to 3f6b9c2 Compare May 4, 2026 11:44
@WilliamRoebuck WilliamRoebuck deployed to workflow-approval May 5, 2026 08:54 — with GitHub Actions Active
@WilliamRoebuck WilliamRoebuck temporarily deployed to workflow-approval May 5, 2026 08:54 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants