-
Notifications
You must be signed in to change notification settings - Fork 19
test: add central S-Core PR checks workflow #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //src:license-checkStatus: Click to expand output |
|
oh great... guess I need to fix that central workflow first 🤣 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new centralized GitHub Actions workflow for S-Core PR checks as a preparatory step toward consolidating multiple existing workflows. The workflow calls a reusable workflow from the eclipse-score/cicd-workflows repository.
Changes:
- Add new
score_on_pr.ymlworkflow that serves as a central entry point for PR checks - Configure the workflow to trigger on pull requests, merge groups, and manual dispatch
- Set up appropriate permissions for automated PR comment creation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Note: "Common" is what will appear on the website as the job name. | ||
| Common: |
Copilot
AI
Jan 15, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The job name 'PR-Checks' uses inconsistent naming convention. Other jobs in the repository use kebab-case (e.g., 'copyright-check', 'formatting-check', 'docs-verify'). Consider renaming to 'pr-checks' to maintain consistency with the existing naming patterns.
| # Note: "Common" is what will appear on the website as the job name. | |
| Common: | |
| # Note: the job identifier uses kebab-case to match repository convention. | |
| pr-checks: |
|
The created documentation from the pull request is available at: docu-html |
This is just preparation. It does not yet replace any of the other workflows.
We can reduce the number of workflows once this central on_pr workflows handles some of them.