Skip to content

bugfix draw function for modules #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaximilianSoerenPollak merged 5 commits into from
Jan 14, 2026
Merged

bugfix draw function for modules #344

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2fb9b75
fix draw function for modules
RolandJentschETAS Jan 14, 2026
f2af928
realy only modules
RolandJentschETAS Jan 14, 2026
749e0b8
format fix
RolandJentschETAS Jan 14, 2026
48cad9b
remove unnecessary double convert
RolandJentschETAS Jan 14, 2026
ad16642
add warning for multiple modules
RolandJentschETAS Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/extensions/score_draw_uml_funcs/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,14 @@ def get_module(component: str, all_needs: dict[str, dict[str, str]]) -> str:
need = all_needs.get(component, {})

if need:
module = need.get("includes_back", "")
# includes_back could deliver multiple needs; only return Modules
parents = need.get("includes_back", [])
module = [pid for pid in parents if all_needs.get(pid, {}).get("type") == "mod"]

if len(module) > 1:
logger.warning(
f"{component}: included in multiple modules: {module}. Returning first."
Copy link
Contributor

@MaximilianSoerenPollak MaximilianSoerenPollak Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be fixed in future PR.

Is it somewhere documented why only the first one is returned?
Or what the logic behind it is?

Copy link
Contributor Author

@RolandJentschETAS RolandJentschETAS Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the implicit logic, that a component belongs only to one module. Module is something like a bazel module or a package. And the component should only be in one. Sure, it could be used or integrated in more then one, but the real implementation should only be in one. I'm not sure if there are any circumstances (base libraries ???) for an exception from this rule, therefore I give only the warning. But in general it is only one. If we want to modify the draw function to show also multiple modules, then I guess more have to be changed. But will discuss this with the colleagues.

)

if module:
return module[0]
Expand Down
Loading