Skip to content

Conversation

@AlexanderLanin
Copy link
Member

@AlexanderLanin AlexanderLanin commented Sep 19, 2025

📌 Description

Some further refactorings to make the final PR #253 smaller

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines

Copilot AI review requested due to automatic review settings September 19, 2025 10:52
@github-project-automation github-project-automation bot moved this from Draft to Done in Infrastructure Sep 19, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in Infrastructure Sep 19, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the YAML parsing logic in the score metamodel extension to improve code organization and maintainability. The changes break down the large load_metamodel_data() function into smaller, focused helper functions while also fixing some data structure inconsistencies.

  • Extracts parsing logic into dedicated helper functions for better separation of concerns
  • Changes default_options() return type from list to set for more efficient operations
  • Fixes a regex pattern in the metamodel configuration

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
yaml_parser.py Major refactoring with new helper functions and improved data structure handling
metamodel_types.py Added spacing and comments for better readability
metamodel.yaml Fixed missing anchor in regex pattern
check_options.py Updated variable names and adapted to use set operations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Sep 19, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 1a948a29-9864-4abd-a4d5-49c3693dd0a3
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (71 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (123 packages loaded, 2288 targets configured)

Analyzing: target //src:license-check (134 packages loaded, 2484 targets configured)

INFO: Analyzed target //src:license-check (137 packages loaded, 4500 targets configured).
[7 / 13] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_tooling+/dash/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 13.008s, Critical Path: 0.34s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

@AlexanderLanin AlexanderLanin merged commit f186b23 into main Sep 23, 2025
21 checks passed
@AlexanderLanin AlexanderLanin deleted the meta2 branch September 23, 2025 15:42
@github-project-automation github-project-automation bot moved this from In Progress to Done in Infrastructure Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants