-
Notifications
You must be signed in to change notification settings - Fork 19
Refactor yaml parsing #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the YAML parsing logic in the score metamodel extension to improve code organization and maintainability. The changes break down the large load_metamodel_data() function into smaller, focused helper functions while also fixing some data structure inconsistencies.
- Extracts parsing logic into dedicated helper functions for better separation of concerns
- Changes
default_options()return type from list to set for more efficient operations - Fixes a regex pattern in the metamodel configuration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| yaml_parser.py | Major refactoring with new helper functions and improved data structure handling |
| metamodel_types.py | Added spacing and comments for better readability |
| metamodel.yaml | Fixed missing anchor in regex pattern |
| check_options.py | Updated variable names and adapted to use set operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
License Check Results🚀 The license check job ran with the Bazel command: bazel run //src:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
📌 Description
Some further refactorings to make the final PR #253 smaller
🚨 Impact Analysis
✅ Checklist