-
Notifications
You must be signed in to change notification settings - Fork 19
fix version switcher #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix version switcher #251
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //src:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes styling issues with the version switcher component in the purple theme by updating CSS selectors and improving color contrast for better readability.
- Replaces ineffective version switcher container styling with targeted button and menu styling
- Adds explicit white text color for version switcher button and menu items
- Removes TODO comment indicating the previous approach wasn't working
Comments suppressed due to low confidence (1)
src/extensions/score_layout/assets/css/score.css:10
- Typo in comment: 'colro' should be 'color'.
A list of available colro variable names for pyData Sphinx Theme can be found at
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
It works! Thanks @MaximilianSoerenPollak ! |
Yet another attempt of making version switcher readable in the new purple style.