-
Notifications
You must be signed in to change notification settings - Fork 19
fix color and make score_layout self-contained #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //src:license-checkStatus: Click to expand output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the score_layout extension to be self-contained by including assets directly in the Python library and simplifies asset path resolution by removing Bazel-specific RUNFILES_DIR logic.
- Includes assets as source files in the score_layout library instead of separate data files
- Replaces complex Bazel runfiles detection with simple Path(file).parent resolution
- Adds CSS color fix for search box and version selection hover background
Reviewed Changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/extensions/score_layout/assets/css/score.css | Adds hover background color for search box and version selection |
| src/extensions/score_layout/init.py | Simplifies asset path resolution and adds logging |
| src/extensions/score_layout/BUILD | Includes assets as source files and reduces dependencies |
| src/BUILD | Removes unused docs_assets filegroup |
| docs.bzl | Removes reference to removed docs_assets |
| MODULE.bazel | Bumps version to 1.3.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
The created documentation from the pull request is available at: docu-html |
|
I'm giving up on the version selecton |
| .version-switcher__container[data-theme="light"] { | ||
| background-color: #a382c5; | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
button.btn.version-switcher__button (for the button itself)
.version-switcher__menu a.list-group-item (for the list that pops out)
These are the two selectors you would need to change the background.
at least works locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both with 'background-color' that was correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MaximilianSoerenPollak I'll have a look. Separate PR, so this one gets merged first of all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries :) Was just bored, so figured it out quickly.
📌 Description
Make the search box readable again

🚨 Impact Analysis
✅ Checklist