Skip to content

Conversation

@AlexanderLanin
Copy link
Member

@AlexanderLanin AlexanderLanin commented Sep 15, 2025

📌 Description

Make the search box readable again
image

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines

@github-actions
Copy link

github-actions bot commented Sep 15, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: d406abf6-e116-497d-a1c6-0c8852511152
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (70 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (123 packages loaded, 2293 targets configured)

Analyzing: target //src:license-check (134 packages loaded, 2484 targets configured)

INFO: Analyzed target //src:license-check (137 packages loaded, 4500 targets configured).
[6 / 13] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_tooling+/dash/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local ... (2 actions, 1 running)
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 12.152s, Critical Path: 0.45s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@AlexanderLanin AlexanderLanin marked this pull request as ready for review September 15, 2025 07:00
Copilot AI review requested due to automatic review settings September 15, 2025 07:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the score_layout extension to be self-contained by including assets directly in the Python library and simplifies asset path resolution by removing Bazel-specific RUNFILES_DIR logic.

  • Includes assets as source files in the score_layout library instead of separate data files
  • Replaces complex Bazel runfiles detection with simple Path(file).parent resolution
  • Adds CSS color fix for search box and version selection hover background

Reviewed Changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/extensions/score_layout/assets/css/score.css Adds hover background color for search box and version selection
src/extensions/score_layout/init.py Simplifies asset path resolution and adds logging
src/extensions/score_layout/BUILD Includes assets as source files and reduces dependencies
src/BUILD Removes unused docs_assets filegroup
docs.bzl Removes reference to removed docs_assets
MODULE.bazel Bumps version to 1.3.0

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

@AlexanderLanin AlexanderLanin marked this pull request as draft September 15, 2025 07:59
@AlexanderLanin
Copy link
Member Author

I'm giving up on the version selecton

@AlexanderLanin AlexanderLanin marked this pull request as ready for review September 15, 2025 08:41
Comment on lines +16 to +19
.version-switcher__container[data-theme="light"] {
background-color: #a382c5;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

button.btn.version-switcher__button (for the button itself)
.version-switcher__menu a.list-group-item (for the list that pops out)

These are the two selectors you would need to change the background.
at least works locally.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both with 'background-color' that was correct.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaximilianSoerenPollak I'll have a look. Separate PR, so this one gets merged first of all.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries :) Was just bored, so figured it out quickly.

@AlexanderLanin AlexanderLanin merged commit 0a20ff5 into eclipse-score:main Sep 15, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from Draft to Done in Infrastructure Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants