Skip to content

Added valgrind and other tools #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olivembo wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −0
Open

Added valgrind and other tools #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2747da0
Added valgrind and other tools
olivembo Jan 20, 2026
38b8c53
Added valgrind and other tools
olivembo Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/s-core-devcontainer/.devcontainer/s-core-local/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,10 @@ apt-get install -y sshpass="${sshpass_version}*"
# additional developer tools
apt-get install -y gdb

apt-get install -y valgrind=1:${valgrind_version}*
apt-get install -y linux-tools-common=${linux_tools_common_version}*
apt-get install -y linux-tools-generic=${linux_tools_generic_version}*

# Bash completion for rust tooling
rustup completions bash rustup >> /etc/bash_completion.d/rustup.bash
rustup completions bash cargo >> /etc/bash_completion.d/cargo.bash
Expand Down
3 changes: 3 additions & 0 deletions src/s-core-devcontainer/.devcontainer/s-core-local/tests/test_default.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ check "validate JAVA_HOME is set correctly" bash -c 'echo $JAVA_HOME | xargs rea
# additional developer tools
check "validate gdb is working and has the correct version" bash -c "gdb --version | grep '${gdb_version}'"
check "validate gh is working and has the correct version" bash -c "gh --version | grep '${gh_version}'"
check "validate valgrind is working and has the correct version" bash -c "valgrind --version | grep '${valgrind_version}'"
check "validate linux_tools_common is working and has the correct version" bash -c "dpkg -s linux-tools-common 2>/dev/null | grep -q 'Version: ${linux_tools_common_version}'"
check "validate linux_tools_generic is working and has the correct version" bash -c "dpkg -s linux-tools-generic 2>/dev/null | grep -q 'Version: ${linux_tools_generic_version}'"

# Qemu target-related tools
check "validate qemu-system-aarch64 is working and has the correct version" bash -c "qemu-system-aarch64 --version | grep '${qemu_system_arm_version}'"
Expand Down
9 changes: 9 additions & 0 deletions src/s-core-devcontainer/.devcontainer/s-core-local/versions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,15 @@ gh:
openjdk_21:
version: "21.0.9"

valgrind:
version: "3.22.0"

linux_tools_common:
version: "6.8.0"

linux_tools_generic:
version: "6.8.0"
Comment on lines +34 to +38
Copy link
Contributor

@lurtz lurtz Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this has some host dependency. E.g. my notebook runs Ubuntu 24.04 with kernel 6.14.0-37-generic and then perf inside this container will not work.

For this I used to create a script called by postCreateCommand and let that one install the matching linux-tools versions.

What do you think about that? Otherwise we will end up installing tons of linux tools packages or constantly updating the container in case the installed Linux kernel version changes.

Copy link
Contributor

@opajonk opajonk Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain where here is a dependency on the kernel version? Since the kernel is shared with the host (obviously), this would be a serious problem...


bazel:
# https://github.com/bazelbuild/bazel/releases -- latest version as of 2025-09-24
version: 8.4.1
Expand Down