Exit gracefully when help is requested #36
Conversation
lurtz
force-pushed
the
exit_gracefully_when_help_is_requested
branch
from
996892f to
19054b0
Compare
|
TODO: Markus Hosch if Rust and C++ example applications need to behave similar UPDATE: Agreed to deal with these fixes in an additional pull request. |
|
@lurtz Please add an issue with bugfix template |
lurtz
force-pushed
the
exit_gracefully_when_help_is_requested
branch
from
a51c904 to
ce51580
Compare
lurtz
changed the title
| - name: Install Bazel until we can use fixed container image with Bazel pre-installed | ||
| run: | | ||
| sudo apt-get update && sudo apt-get install -y --allow-downgrades bazel=$(cat .bazelversion) |
There was a problem hiding this comment.
We do not want to install Bazel here. Either we would use one of the preexisting GitHub Actions to use Bazelisk - or assume its installed in the dev-container.
See for example:
uses: bazel-contrib/setup-bazel@0.15.0
with:
bazelisk-cache: true
disk-cache: ${{ github.workflow }}
repository-cache: true
There was a problem hiding this comment.
The container ships bazel 8.3.0, but this code still build with bazel 7.5.0 (see #58). For this reason bazel is downgraded. The alternative is to merge the other PR.
I did not dare to upgrade bazel here, because I do not know if that will cause trouble at BMW
There was a problem hiding this comment.
its now pinned, so you can drop this commit if you want, then we can go with the other commit.
There was a problem hiding this comment.
do you see the change to use the devcontainer image later in time? At the moment it is still not possible to create version tags for the score/devcontainer and I would like to reintroduce the devcontainer in CI, when it is possible. I thought that creation of versions would be done quicker.
There was a problem hiding this comment.
I do not know about the dev-container and what its goals are
There was a problem hiding this comment.
The source is here: https://github.com/eclipse-score/devcontainer
The original request here: eclipse-score/score#1256
The goal is to decouple host and development / CI environment. Thus you always use the tools provided by the devcontainer image to build and test the code.
E.g. in the Github Action you now specified that it runs on Ubuntu 24.04. Thus to exactly reproduce what CI did, I also have to run Ubuntu 24.04 (which is also used by the devcontainer). If CI and developers use the same image there is no chance they have different OS versions or tooling, when the container images are specified with fixed versions, which we do not have yet.
Using --help should not be an exceptional case. Instead it is always valid to use.
lurtz
force-pushed
the
exit_gracefully_when_help_is_requested
branch
from
ce51580 to
dddd63c
Compare
lurtz
changed the title
|
Under Integration |
4 participants
Using --help should not be an exceptional case. Instead it is always valid to use.