-
Notifications
You must be signed in to change notification settings - Fork 39
Add devcontainer #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add devcontainer #23
Conversation
|
Future changes in this PR will make use of what is done in https://github.com/Elektrobit/eclipse-score_devkit/pull/1 |
opajonk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only this one thing that needs to be updated after the first devcontainer is built and published.
This makes it way easier to compile, run and debug code without huge setup efforts.
|
In vscode on mac (apple silicon) it runs into this error during setup: It is executed as x86_64 container (emulated in docker in a virtual machine): Running natively on x86_64 linux it seems to work, however not with vscode remote via ssh and then using the devcontainer... it's weird, because that's a pretty common setup for me. Will try to find out more. Supplemental: even locally on the x86_64 linux I get weird disconnects (vscode running local devcontainers) - I can't see anything more than that I'm afraid. Please double check the container image. I get disconnected from it after working with it for less than five minutes on native x86_64 linux |
Here I cannot support. I lack the hardware and OS.
That is really odd. I executed the devcontainer on the following OS's without the issue you observed:
In both cases I was able to compile and test the code. On both notebooks VS Code is still running with the container and all I did was pressing the In both cases I am using a very simple setup. What did you do differently than what I did? |
I probably went a bit crazy on my linux setup and super-customized it, looks like I broke vscode's ability to use docker devcontainers completly, this was just the first one where that occurred... On a standard ubuntu 22.04 it works fine, also via ssh + devcontainers. The applie-silicon issue still bothers me, but having a container that works for linux is definitely a step forward we should take rather than figure out every little niche problem. |
MarkSchmitt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, tested with an ubuntu 22.04 host. I did have some weird issues on a apple silicon mac .. but I think we should still go ahead and tackle that later.
opajonk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latest is good for the start. When we have some tagged containers and "the dust has settled" we should switch to versioned releases, though.
|
Lgtm - tried it on ubuntu. |
|
I believe #31 will fix the CI/CD failure we see also in this PR. |
Nice someone else fixed my issues |
Co-authored-by: Oliver Pajonk <oliver@pjnk.de> Signed-off-by: lurtz <727209+lurtz@users.noreply.github.com>
This makes it way easier to compile, run and debug code without huge setup efforts.
depends on https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/6389 to publish images via https://github.com/eclipse-score/devcontainer
Is in relation to eclipse-score/score#1256