rust: implement Reloc macro #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelrutkaq
requested review from
LittleHuba,
castler and
hoe-jo
as code owners
pawelrutkaq
force-pushed
the
pawelrutkaq_reloc_macro
branch
from
caabeb2 to
c95b4ec
Compare
pawelrutkaq
force-pushed
the
pawelrutkaq_reloc_macro
branch
3 times, most recently
from
de95e9e to
d60f6a7
Compare
pawelrutkaq
force-pushed
the
pawelrutkaq_reloc_macro
branch
from
d60f6a7 to
ea0f06c
Compare
Contributor
Author
Contributor
There was a problem hiding this comment.
Can we have different name of this file, as we are not using lib.rs naming in com-api lib.
Contributor
Author
There was a problem hiding this comment.
Isnt lib.rs a general Rust convention for lib crates ? Bit confused.
Contributor
There was a problem hiding this comment.
We can use lib.rs, i just mentioned because our all the files naming is based on module name in com-api , so to make file naming consistent i have suggested.
Contributor
Author
There was a problem hiding this comment.
as we talked, I keep lib.rs as all other codebase in score uses lib.rs
pawelrutkaq
force-pushed
the
pawelrutkaq_reloc_macro
branch
from
ea0f06c to
6eb53d4
Compare
Contributor
Author
|
@LittleHuba can we sync this ? |
pawelrutkaq
force-pushed
the
pawelrutkaq_reloc_macro
branch
from
6eb53d4 to
e720eb8
Compare
pawelrutkaq
force-pushed
the
pawelrutkaq_reloc_macro
branch
from
e720eb8 to
b50cb6d
Compare
LittleHuba
added
the
import-started-do-not-modify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.