-
Notifications
You must be signed in to change notification settings - Fork 39
Add flatbuffer support for COM configuration using flatbuffers #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add flatbuffer support for COM configuration using flatbuffers #112
Conversation
|
Thank you for sharing this initial version of the flatbuffer support. |
|
See also general discussion here: #110 |
| { | ||
| if (ShouldUseFlatBuffer(path)) | ||
| { | ||
| // Warning is used to see usage in the default ipc bridge test setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change back to info before merging PR. Warning is currently only used to see effect in ipc bridge test.
Same applies to json log.
46dea4b to
75dcfcc
Compare
Signed-off-by: KaitoKid <thomas.mikhael@icloud.com>
| } | ||
|
|
||
| auto config = configuration::Parse(runtime_configuration.GetConfigurationPath().Native()); | ||
| auto config = configuration::Load(runtime_configuration.GetConfigurationPath().Native()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LittleHuba @castler @hoe-jo:
I guess we should first decide on the scope of this PR.
We could for example leave out this change to not yet allow for actual usage of flatbuffers by a user of COM and only introduce a initial set of changes e.g.:
- mw/com/impl/configuration
- ara_com_config.fbs
- flatbuffer_config_loader.h/cpp
- including the respective quality artifacts architecture, ..., tests
- bazel/tools
Please coordinate with @Thomas-Mikhael he will takeover the PR.
resolves #110
This initial version was focused on working ipc bridge test using flatbuffers, quality aspects are not yet covered.
It is recommended to break down the issue into smaller tasks and setup a merge strategy, PR is therefore draft only.
Pending decisions:
Changes (rough outline)
Open points: