Skip to content

[Compare] Apply editor selection colors to merge viewer panes#2657

Open
tobiasmelcher wants to merge 2 commits into
eclipse-platform:masterfrom
tobiasmelcher:selection_colors
Open

[Compare] Apply editor selection colors to merge viewer panes#2657
tobiasmelcher wants to merge 2 commits into
eclipse-platform:masterfrom
tobiasmelcher:selection_colors

Conversation

@tobiasmelcher
Copy link
Copy Markdown
Contributor

Respect the configured selection foreground/background colors from editor preferences in the TextMergeViewer, including live updates when preferences change.

Respect the configured selection foreground/background colors from
editor preferences in the TextMergeViewer, including live updates when
preferences change.
@tobiasmelcher tobiasmelcher requested a review from HannesWell May 11, 2026 15:52
@tobiasmelcher
Copy link
Copy Markdown
Contributor Author

The selection background/foreground colors set in the preferences under General->Editors->Text Editors were only used in the "Java Compsare" view, not in the "Text Compare". This pull request fixes this issue.

image

@github-actions
Copy link
Copy Markdown
Contributor

Test Results

    54 files  +    5      54 suites  +5   35m 42s ⏱️ + 2m 41s
 4 666 tests ±    0   4 644 ✅ ±    0   22 💤 ±0  0 ❌ ±0 
11 892 runs  +1 183  11 739 ✅ +1 183  153 💤 ±0  0 ❌ ±0 

Results for commit f72e421. ± Comparison against base commit 327e3b8.

@iloveeclipse
Copy link
Copy Markdown
Member

The selection background/foreground colors set in the preferences under General->Editors->Text Editors were only used in the "Java Compsare" view, not in the "Text Compare". This pull request fixes this issue.

image

Is this screenshot before or after the change?

@tobiasmelcher
Copy link
Copy Markdown
Contributor Author

We got this error reported from Mac users when working with the dark theme. Following screenshots show the state without this pull request.

Here the preference page showing the selection foreground/background colors:
preferences_selection_color

In the "Java Compare" editor these color settings are correctly taken:
selection_color_java_compare

After switching to the "Text Compare" the selection colors are not correct (they are from the light theme):
selection_color_text_compare

This pull request ensures that the correct selection foreground/background colors are also taken in the "Text Compare" view of the compare editor.

Copy link
Copy Markdown
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants