Add active launch indicator to launch history menu#2652
Add active launch indicator to launch history menu#2652SougandhS wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
|
Since recently the "circle" was added to indicate changed file, I would not use this for running launch config, it would be confusing. What about simple "(running)" label? |
I went with this first, but It felt bit long... 
|
How about 
|
How about \u2699 ( ⚙ "gear" ) or \u1F3C3 ( 🏃 "running man" ) ? |
Gear looks great !
this doesn't render 😅 |
|
The change is simple and nice, do we really need an option for that? If yes, please enable by default. |
| ILaunch[] launches = DebugPlugin.getDefault().getLaunchManager().getLaunches(); | ||
| IPreferenceStore store = DebugUIPlugin.getDefault().getPreferenceStore(); | ||
| boolean launchPref = store.getBoolean(IInternalDebugUIConstants.PREF_LAUNCHED_INDICATOR); | ||
| for (ILaunchConfiguration launch : favoriteList) { |
There was a problem hiding this comment.
Can you please guard the new code, including fetching of the launch configs by first check if launchPref is set? Same below.
There was a problem hiding this comment.
Added a length check for launches
|
If unicode symbol is to be used - extra testing is needed that the chosen one is widely available in default fonts as per (https://eclipse.dev/eclipse/development/plans/eclipse_project_plan_4_40.xml#target_environments) and ideally in some popular fonts(whatever they are) and last but not least verify on all platform that nothing bad happens when a font that doesn't contain the symbol is used. |
Please no option for such things. We already have more options than one can find and manage. |
Adds a visual indicator to launch configurations that are currently active in the launch history menu.
Removed all the preference parts 👍 |
Thanks, I'll try to check in these platforms.. |
See also https://stackoverflow.com/questions/48468088/unicode-character-uncompatibility At least on RHEL 9.6 with "Sans Serif" dialog font (whatever system means with that name) it looks OK. |
|
Hi @iloveeclipse, @akurtakov, how about adding overlay image ? |
Why not, but then maybe the one with the green "Run" arrow like on the Progress view icon? |
|
I have a preference to (widely spread) unicode symbol as (at least on Linux) these autoadjust contrast on changes of Gtk theme. Also they are less resource hungry and auto managed by OS instead of images that have to be destroyed and etc. |
3 participants
Adds support to show an active launch indicator in the launch history menu, helping users quickly identify which launch configurations are currently running from launch history. Entries with associated non-terminated launches are marked with a visual indicator "●" ,Once the indicator is shown, users can immediately recognize that the configuration is already running, helping avoid unnecessary or unintended clicks from the launch history menu. The feature is controlled by the preference
and is applied only when enabled, ensuring no change to existing behavior by default.
With Active (Running)
With In-Active (Terminated or not launched)