Test the validity of configuration element before accessing attributes#2600
Open
eric-milles wants to merge 1 commit intoeclipse-platform:masterfrom
Open
Test the validity of configuration element before accessing attributes#2600eric-milles wants to merge 1 commit intoeclipse-platform:masterfrom
eric-milles wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
eric-milles
force-pushed
the
issue2593
branch
3 times, most recently
from
a85e167 to
064eb24
Compare
Author
Is this something that is supposed to be changed elsewhere? Or is the expectation that I bump the version? |
Author
|
There is still not a version difference in the current master branch. Am I supposed to bump the version in the manifest? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
IConfigurationElement.getAttributemethod throwsInvalidRegistryObjectException. CheckisValid()before accessing attributes to prevent uncaught exception.see #2593