Make Terminal operate on and cache colors instead of RGB values#2481
Draft
HeikoKlare wants to merge 1 commit intoeclipse-platform:masterfrom
Draft
Make Terminal operate on and cache colors instead of RGB values#2481HeikoKlare wants to merge 1 commit intoeclipse-platform:masterfrom
HeikoKlare wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
laeubi
reviewed
Feb 26, 2026
| RGB rgb = null; | ||
| if (fPreferenceStore != null) { | ||
| try { | ||
| rgb = StringConverter.asRGB( |
Contributor
There was a problem hiding this comment.
should this here not be an color already?
Contributor
Author
There was a problem hiding this comment.
It's an RGB value that is later wrapped into a color.
laeubi
reviewed
Feb 26, 2026
| @@ -694,7 +695,7 @@ | |||
| if (rgb == null) { | |||
| rgb = TerminalColorPresets.INSTANCE.getDefaultPreset().getRGB(terminalColor); | |||
laeubi
reviewed
Feb 26, 2026
Comment on lines
+88
to
+89
| Color defaultFg = fStyleMap.getForegroundColor(null); | ||
| doubleBufferGC.setForeground(defaultFg); |
Contributor
There was a problem hiding this comment.
as we have Color getDefaultBackgroundColor() should the not better be a Color getForegroundColor() as well?
This would prevent repeating the code used here and in setupGC
Contributor
Author
There was a problem hiding this comment.
It's not a repetition as here it's about the default color (style == null) and in setupGC its the style-specific color. We can of course introduce additional methods like getDefaultForegroundColor() or the like, but it's will only be for consistency, not for reuse.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.