Wait on initial dialog processing in QuickAccessDialogTest#4024
Merged
Conversation
This change adjusts QuickAccessDialogTest.testPreviousChoicesAvailableForExtension() to show initial Quick Access dialog contents and wait on these contents. This hopefully avoids race conditions between asynchronous dialog processing and test code setting dialog text. See: eclipse-platform#4009
Contributor
Contributor
Author
|
@iloveeclipse is there a problem to merge this right now? Or should I wait some time? |
Contributor
|
Given it's a currently flaky test that you're trying to fix, merging during the freeze period is fine. Please go ahead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adjusts
QuickAccessDialogTest.testPreviousChoicesAvailableForExtension()to show initial Quick Access dialog contents and wait on these contents. This hopefully avoids race conditions between asynchronous dialog processing and test code setting dialog text.See: #4009