Skip to content

[#2242] fix wrong hover size of MarkerInformationControl#4021

Open
markdomeng wants to merge 1 commit into
eclipse-platform:masterfrom
markdomeng:fix_MarkerInformationControl
Open

[#2242] fix wrong hover size of MarkerInformationControl#4021
markdomeng wants to merge 1 commit into
eclipse-platform:masterfrom
markdomeng:fix_MarkerInformationControl

Conversation

@markdomeng
Copy link
Copy Markdown

the size of marker hover being set to a very small value (2,2) was fixed in c8ddf0f but now it is getting the max size of the shell which is very large

solution is to pack the actual shell that contains the children of the marker control, and compute the size manually

the size of marker hover being set to a very small value (2,2) was fixed  in c8ddf0f
but now it is getting the max size of the shell which is very large

solution is to pack the actual shell that contains the children of the marker control, and compute the size manually
@iloveeclipse
Copy link
Copy Markdown
Member

@markdomeng : could you please provide screenshots before / after and steps to reproduce?

@github-actions
Copy link
Copy Markdown
Contributor

Test Results

   858 files   -   6     858 suites   - 6   46m 49s ⏱️ - 7m 56s
 7 792 tests  - 196   7 551 ✅  - 194  241 💤  -  2  0 ❌ ±0 
19 842 runs   - 576  19 208 ✅  - 555  634 💤  - 21  0 ❌ ±0 

Results for commit 7a51abb. ± Comparison against base commit a086677.

This pull request removes 196 tests.
org.eclipse.ui.genericeditor.tests.AutoEditTest ‑ testAutoEdit
org.eclipse.ui.genericeditor.tests.AutoEditTest ‑ testEnabledWhenAutoEdit
org.eclipse.ui.genericeditor.tests.BasicEditionTest ‑ testNewLineHasIndent
org.eclipse.ui.genericeditor.tests.CompletionTest ‑ testCompletion
org.eclipse.ui.genericeditor.tests.CompletionTest ‑ testCompletionFreeze_bug521484
org.eclipse.ui.genericeditor.tests.CompletionTest ‑ testCompletionService
org.eclipse.ui.genericeditor.tests.CompletionTest ‑ testCompletionUsingViewerSelection
org.eclipse.ui.genericeditor.tests.CompletionTest ‑ testDefaultContentAssistBug570488
org.eclipse.ui.genericeditor.tests.CompletionTest ‑ testEnabledWhenCompletion
org.eclipse.ui.genericeditor.tests.CompletionTest ‑ testMoveCaretBackUsesAllProcessors_bug522255
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants