Revert "QuickAccessDialog: render filter as native search field"#4018
Closed
vogella wants to merge 1 commit into
Closed
Revert "QuickAccessDialog: render filter as native search field"#4018vogella wants to merge 1 commit into
vogella wants to merge 1 commit into
Conversation
This reverts commit b7b54fc.
Contributor
Author
|
Shall this be merged? cc @HeikoKlare and @akurtakov ? |
Contributor
|
Could you please explain the intent of this PR? Without that it's impossible to answer that question. |
Member
|
This seems to be due to my guess about SEARCH potentially exposing limitations on MacOS, which Heiko corrected me as being seen on Windows too. So I would dare to say - this shouldn't be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #3916