Skip to content

Remove internal ICU support from databinding API#3985

Draft
vogella wants to merge 2 commits intoeclipse-platform:masterfrom
vogella:icu
Draft

Remove internal ICU support from databinding API#3985
vogella wants to merge 2 commits intoeclipse-platform:masterfrom
vogella:icu

Conversation

@vogella
Copy link
Copy Markdown
Contributor

@vogella vogella commented May 7, 2026

The public ICU-based databinding API was removed in 2022 (commit 616243f). This change removes the remaining internal reflective fallbacks to com.ibm.icu.text.NumberFormat and com.ibm.icu.math.BigDecimal in org.eclipse.core.databinding, completing the transition to java.text. Java 17 (the bundle's BREE) handles BigDecimal parsing/formatting correctly via DecimalFormat#setParseBigDecimal(true), which is already used. Also drops two stale Javadoc references that contrasted these classes with sibling classes that no longer exist.

Planned for 4.41.

vogella and others added 2 commits May 8, 2026 01:30
Public ICU-based databinding API was removed in 2022. This change
removes the remaining internal reflective support and documentation
references to com.ibm.icu, completing the transition to java.text.
@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.core.databinding/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 317d53a26bd3c0051f3616a4e8e67fb68e1a5c71 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Thu, 7 May 2026 23:36:32 +0000
Subject: [PATCH] Version bump(s) for 4.40 stream


diff --git a/bundles/org.eclipse.core.databinding/META-INF/MANIFEST.MF b/bundles/org.eclipse.core.databinding/META-INF/MANIFEST.MF
index 12009435d8..da03b94e72 100644
--- a/bundles/org.eclipse.core.databinding/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.core.databinding/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.core.databinding
-Bundle-Version: 1.13.700.qualifier
+Bundle-Version: 1.13.800.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Export-Package: org.eclipse.core.databinding;version="1.0.0",
-- 
2.53.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Test Results

   345 files   -   513     345 suites   - 513   56m 50s ⏱️ + 2m 23s
 6 908 tests  - 1 069   6 667 ✅  - 1 067  241 💤  - 2  0 ❌ ±0 
17 226 runs   - 3 207  16 577 ✅  - 3 201  649 💤  - 6  0 ❌ ±0 

Results for commit 98f50dc. ± Comparison against base commit a2d8374.

This pull request removes 1069 tests.
org.eclipse.core.tests.databinding.AggregateValidationStatusTest ‑ testAggregateValidationStatusValueType
org.eclipse.core.tests.databinding.AggregateValidationStatusTest ‑ testConstructor_DefaultRealm
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeBindingThenModel
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeBindingThenObservables
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeBindingThenTarget
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeModelDisposesBinding
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeModelThenBinding
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeObservablesThenBinding
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeTargetDisposesBinding
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeTargetThenBinding
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants