Fix sticky scroll height calculation for variable line heights#3748
Closed
utafrali wants to merge 1 commit intoeclipse-platform:masterfrom
Closed
Conversation
…ScrollingControl Replace parameterless getLineHeight() calls with the offset-aware getLineHeight(int offset) variant to correctly account for lines containing emoji or other extended characters that increase line height. - In calculateAndSetStickyLinesCanvasBounds(), sum per-line heights using stickyLineText.getLineHeight(offset) so the canvas bounds accurately reflect the actual rendered height of each sticky line. - In limitVisibleStickyLinesToTextWidgetHeight(), use textWidget.getLineHeight(topOffset) so the visible line count estimate respects the actual height of the top visible line.
Member
|
@Christopher-Hermann can you pls. review? |
Author
|
Closing — can't sign the ECA. |
Member
You mean, there is a technical problem or you won't sign? |
Author
|
Honestly I'm not comfortable with the obligations that come with signing the ECA — I feel like it goes against the open source spirit. Closing this one out. |
Member
Could you please give some example? Eclipse contributors agreement is nowhere against open source. Whole Eclipse Foundation and all open source projects hosted here are based on work of people signed ECA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When emoji or other content affects line heights, sticky scroll was calculating the total height wrong by assuming all lines were the same. Now it gets the actual height for each line instead. Also fixes the height check for limiting visible lines.