Search View: Performance issues on remove and sort by mehmet-karaman · Pull Request #3733 · eclipse-platform/eclipse.platform.ui

mehmet-karaman · 2026-02-17T14:17:58Z

Implemented a batch removal of search matches
Search matches are removed from their parent, instead of one by one
which causes performance issues
It's also fixing the problem, that all elements are removed instead
only the visible elements (while all others are filtered by the limit
number)
Replaces the
ConcurrentHashMap.newKeySet() with the ConcurrentSkipListSet with the
comparator and makes the additional sorting obsolete.

iloveeclipse · 2026-02-17T14:21:47Z

@mehmet-karaman : please first create a ticket and explain the problem.
Note: you seem to use wrong git author mail, please use same which you've used in ECA process.

github-actions · 2026-02-17T15:34:19Z

Test Results

3 018 files - 6 3 018 suites - 6 2h 13m 53s ⏱️ - 2m 51s
8 237 tests + 3 7 989 ✅ + 3 248 💤 ±0 0 ❌ ±0
23 509 runs - 17 22 721 ✅ - 14 788 💤 - 3 0 ❌ ±0

Results for commit 6ffeee4. ± Comparison against base commit 89a19bf.

♻️ This comment has been updated with latest results.

bundles/org.eclipse.search/newsearch/org/eclipse/search/ui/text/AbstractTextSearchResult.java

bundles/org.eclipse.search/newsearch/org/eclipse/search/ui/text/AbstractTextSearchViewPage.java

bundles/org.eclipse.search/newsearch/org/eclipse/search/ui/text/AbstractTextSearchResult.java

Copilot

Pull request overview

This PR addresses Search View performance and correctness when removing matches, by enabling batch removal at the “enclosing element” (e.g., file/resource) level and ensuring removals aren’t limited to only currently visible (element-limited) results.

Changes:

Updated AbstractTextSearchViewPage.internalRemoveSelected() to batch-remove matches by selected IFile / IContainer resources before falling back to per-match removal for non-resource selections.
Added AbstractTextSearchResult.removeElements(...) to remove all matches for selected elements via a single map-entry removal per element.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
`bundles/org.eclipse.search/newsearch/org/eclipse/search/ui/text/AbstractTextSearchViewPage.java`	Adds resource-aware pre-processing in “Remove Selected Matches” to remove matches by file/container in a batch.
`bundles/org.eclipse.search/newsearch/org/eclipse/search/ui/text/AbstractTextSearchResult.java`	Introduces an element-based batch removal method to efficiently drop all matches for selected elements.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

bundles/org.eclipse.search/newsearch/org/eclipse/search/ui/text/AbstractTextSearchViewPage.java

bundles/org.eclipse.search/newsearch/org/eclipse/search/ui/text/AbstractTextSearchResult.java

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

bundles/org.eclipse.search/newsearch/org/eclipse/search/ui/text/AbstractTextSearchViewPage.java

bundles/org.eclipse.search/newsearch/org/eclipse/search/ui/text/AbstractTextSearchResult.java

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

bundles/org.eclipse.search/newsearch/org/eclipse/search/ui/text/AbstractTextSearchResult.java

bundles/org.eclipse.search/newsearch/org/eclipse/search/ui/text/AbstractTextSearchViewPage.java

mehmet-karaman · 2026-02-23T16:11:16Z

I am going to try to reproduce the failure locally..

iloveeclipse · 2026-02-23T16:21:07Z

Seems that the default is table view and not tree.

I assume this be forced by using right preference for the search, but I haven't checked what is the probllem with the test. Note: you must "process UI events loop" in order to see fully updated search view after some search job is executed, this could be the problem you observe.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

bundles/org.eclipse.search/newsearch/org/eclipse/search/ui/text/AbstractTextSearchResult.java

tests/org.eclipse.search.tests/src/org/eclipse/search/tests/TextSearchResultTest.java

mehmet-karaman · 2026-02-23T22:15:57Z

Seems that the default is table view and not tree.

I assume this be forced by using right preference for the search, but I haven't checked what is the probllem with the test. Note: you must "process UI events loop" in order to see fully updated search view after some search job is executed, this could be the problem you observe.

Your guess was correct, It was failing due to pending UI events.. The tests are running now, but another test is failing. Could be that I have to set the default value back in tearDown.. This is also pushed now.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

bundles/org.eclipse.search/newsearch/org/eclipse/search/ui/text/AbstractTextSearchResult.java

bundles/org.eclipse.search/newsearch/org/eclipse/search/ui/text/AbstractTextSearchViewPage.java

tests/org.eclipse.search.tests/src/org/eclipse/search/tests/TextSearchResultTest.java

bundles/org.eclipse.search/newsearch/org/eclipse/search/ui/text/AbstractTextSearchResult.java

tests/org.eclipse.search.tests/src/org/eclipse/search/tests/TextSearchResultTest.java

bundles/org.eclipse.search/newsearch/org/eclipse/search/ui/text/AbstractTextSearchResult.java

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/org.eclipse.search.tests/src/org/eclipse/search/tests/TextSearchResultTest.java

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/org.eclipse.search.tests/src/org/eclipse/search/tests/TextSearchResultTest.java

- Implemented a batch removal of search matches - Search matches are removed from their parent, instead of one by one which causes performance issues - It's also fixing the problem, that all elements are removed instead only the visible elements (while all others are filtered by the limit number) - Replaces the ConcurrentHashMap.newKeySet() with the ConcurrentSkipListSet with the comparator and makes the additional sorting obsolete. - After this change, avoid using `size()` on values, because it is not more constant time operation, see `ConcurrentSkipListSet` javadoc. - Also comparator must be changed to consider different Match elements with same size and offsets in the set - otherwise the `ConcurrentSkipListSet` would lost them. - Added `AbstractTextSearchResult.hasMatches(Object element)` API for cases where match count not needed. - If possible, calls to `size()` changed to `isEmpty()` or omitted. - Implemented Tests Fixes eclipse-platform#3735 Co-authored-by: Andrey Loskutov <loskutov@gmx.de>

mehmet-karaman · 2026-02-26T09:57:02Z

Resolved all comments .. (force pushed one last commit hopefully)

mehmet-karaman · 2026-02-26T14:19:05Z

I've ran the RcpTestSuite locally many times and never run into a timeout.

iloveeclipse · 2026-02-26T14:37:57Z

I've ran the RcpTestSuite locally many times and never run into a timeout.

As discussed, please check existing tickets and if there is no one, report this test and if there is one, check the test failure whether it is still same or not.

mehmet-karaman · 2026-02-26T20:57:36Z

Due to hint of @vogella this was a known issue: #1517

I guess we are done with this PR now.

mehmet-karaman force-pushed the batch_remove_search_matches branch from 2a62c61 to 73cab0d Compare February 17, 2026 14:52

mehmet-karaman force-pushed the batch_remove_search_matches branch 4 times, most recently from dff7693 to 300ca6b Compare February 17, 2026 23:07

iloveeclipse requested changes Feb 18, 2026

View reviewed changes

mehmet-karaman force-pushed the batch_remove_search_matches branch from 300ca6b to fe5e861 Compare February 18, 2026 22:21

mehmet-karaman commented Feb 18, 2026

View reviewed changes

bundles/org.eclipse.search/newsearch/org/eclipse/search/ui/text/AbstractTextSearchResult.java Outdated Show resolved Hide resolved

mehmet-karaman force-pushed the batch_remove_search_matches branch from fe5e861 to 7f02394 Compare February 18, 2026 23:19

iloveeclipse requested a review from Copilot February 19, 2026 08:03

Copilot started reviewing on behalf of iloveeclipse February 19, 2026 08:04 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

fedejeanne mentioned this pull request Feb 19, 2026

Search view with millions of matches is freezing the UI #3735

Open

mehmet-karaman force-pushed the batch_remove_search_matches branch 2 times, most recently from 4cd364f to b53503b Compare February 19, 2026 11:20

mehmet-karaman changed the title ~~Search View: Batch removing of search matches~~ Search View: Performance issues on remove and sort Feb 19, 2026

iloveeclipse requested a review from Copilot February 19, 2026 11:56

Copilot started reviewing on behalf of iloveeclipse February 19, 2026 11:56 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

bundles/org.eclipse.search/newsearch/org/eclipse/search/ui/text/AbstractTextSearchViewPage.java Outdated Show resolved Hide resolved

bundles/org.eclipse.search/newsearch/org/eclipse/search/ui/text/AbstractTextSearchResult.java Outdated Show resolved Hide resolved

mehmet-karaman force-pushed the batch_remove_search_matches branch 2 times, most recently from 17ec4af to fc2f401 Compare February 19, 2026 12:46

iloveeclipse reviewed Feb 19, 2026

View reviewed changes

bundles/org.eclipse.search/newsearch/org/eclipse/search/ui/text/AbstractTextSearchResult.java Outdated Show resolved Hide resolved

iloveeclipse force-pushed the batch_remove_search_matches branch from fc2f401 to 40ee202 Compare February 19, 2026 13:48

iloveeclipse requested a review from Copilot February 19, 2026 14:12

Copilot started reviewing on behalf of iloveeclipse February 19, 2026 14:12 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

iloveeclipse force-pushed the batch_remove_search_matches branch from 40ee202 to 7d37158 Compare February 19, 2026 15:13

mehmet-karaman force-pushed the batch_remove_search_matches branch from 7d37158 to d572e09 Compare February 20, 2026 11:22

iloveeclipse requested a review from Copilot February 23, 2026 20:09

Copilot started reviewing on behalf of iloveeclipse February 23, 2026 20:10 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

mehmet-karaman force-pushed the batch_remove_search_matches branch 2 times, most recently from d53e827 to 47c1437 Compare February 23, 2026 22:08

mehmet-karaman force-pushed the batch_remove_search_matches branch 2 times, most recently from 26d440a to c7599f8 Compare February 24, 2026 11:10

iloveeclipse requested a review from Copilot February 25, 2026 07:26

Copilot started reviewing on behalf of iloveeclipse February 25, 2026 07:27 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

mehmet-karaman force-pushed the batch_remove_search_matches branch 2 times, most recently from 07fe961 to 127e48e Compare February 25, 2026 09:31

iloveeclipse requested a review from Copilot February 25, 2026 09:41

Copilot started reviewing on behalf of iloveeclipse February 25, 2026 09:41 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

mehmet-karaman force-pushed the batch_remove_search_matches branch from 127e48e to 66dda3f Compare February 25, 2026 10:10

iloveeclipse requested a review from Copilot February 25, 2026 10:19

Copilot started reviewing on behalf of iloveeclipse February 25, 2026 10:19 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

tests/org.eclipse.search.tests/src/org/eclipse/search/tests/TextSearchResultTest.java Show resolved Hide resolved

mehmet-karaman force-pushed the batch_remove_search_matches branch from 66dda3f to 27539cf Compare February 25, 2026 13:12

mehmet-karaman force-pushed the batch_remove_search_matches branch from 27539cf to 6ffeee4 Compare February 26, 2026 09:51

mehmet-karaman mentioned this pull request Feb 26, 2026

Sporadic testfailures in org.eclipse.ui.tests.rcp on Windows #3747

Closed

Conversation

mehmet-karaman commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iloveeclipse commented Feb 17, 2026

Uh oh!

github-actions bot commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mehmet-karaman commented Feb 23, 2026

Uh oh!

iloveeclipse commented Feb 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mehmet-karaman commented Feb 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

mehmet-karaman commented Feb 26, 2026

Uh oh!

mehmet-karaman commented Feb 26, 2026

mehmet-karaman commented Feb 17, 2026 •

edited

Loading

github-actions bot commented Feb 17, 2026 •

edited

Loading

mehmet-karaman commented Feb 26, 2026 •

edited

Loading