Take line spacing into account in code mining drawing logic #3651
+38
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BeckerWdf
approved these changes
Jan 9, 2026
BeckerWdf
approved these changes
Jan 9, 2026
...xt.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningLineHeaderAnnotationTest.java
Outdated
Show resolved
Hide resolved
tobiasmelcher
force-pushed
the
line_spacing_code_mining
branch
from
d1997c1 to
904af91
Compare
BeckerWdf
approved these changes
Jan 9, 2026
vogella
force-pushed
the
line_spacing_code_mining
branch
from
904af91 to
c302656
Compare
tobiasmelcher
force-pushed
the
line_spacing_code_mining
branch
from
c302656 to
29e3c30
Compare
mickaelistria
approved these changes
Jan 12, 2026
Contributor
|
Please merge, we already have two approvals |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.