Skip to content

Fix #3463: Hide icons in chevron menu when preference is enabled #3489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fedejeanne merged 1 commit into from
Jan 13, 2026
Merged

Fix #3463: Hide icons in chevron menu when preference is enabled #3489

fedejeanne merged 1 commit into from
Jan 13, 2026

Conversation

@laeubi
Copy link
Contributor

@laeubi laeubi commented Nov 3, 2025

No description provided.

@laeubi laeubi requested a review from fedejeanne November 3, 2025 13:00
@laeubi laeubi linked an issue Nov 3, 2025 that may be closed by this pull request
Icons are visible in the chevron even if the preference "Hide icons" is set to true #3463
Closed
2 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025 •
edited
Loading

Test Results

 3 015 files   3 015 suites   2h 10m 43s ⏱️
 8 266 tests  8 017 ✅ 248 💤 1 ❌
23 622 runs  22 830 ✅ 791 💤 1 ❌

For more details on these failures, see this check.

Results for commit f5546f7.

♻️ This comment has been updated with latest results.

@fedejeanne fedejeanne mentioned this pull request Nov 18, 2025
Merged
1 task
@fedejeanne fedejeanne force-pushed the fix-1331477-485750151-b3810fb9-7c32-4159-81c5-cad6806a87c1 branch from 350ca49 to bad4685 Compare November 18, 2025 08:16
fedejeanne
fedejeanne approved these changes Nov 18, 2025
View reviewed changes
Copy link
Member

@fedejeanne fedejeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only changed the commit text, the rest LGTM ✔️

Any objections with merging this for M3 @laeubi / @BeckerWdf ?

@laeubi
Copy link
Contributor Author

laeubi commented Nov 18, 2025

I only changed the commit text, the rest LGTM ✔️

Any objections with merging this for M3 @laeubi / @BeckerWdf ?

We are already at RC1 (see freeze check)

@fedejeanne
Copy link
Member

fedejeanne commented Nov 18, 2025

Any objections with merging this for M3 @laeubi / @BeckerWdf ?

Ah, freeze period. Then I guess we'll wait for M1, I don't see this as urgent

@fedejeanne
Copy link
Member

fedejeanne commented Nov 18, 2025

Failing test are unrelated:

@laeubi laeubi closed this Dec 17, 2025
@fedejeanne
Copy link
Member

fedejeanne commented Jan 2, 2026

Hello @laeubi, I just came back from my long holidays to find this PR closed. May I ask why? Was there something wrong with the code?

@fedejeanne
Copy link
Member

fedejeanne commented Jan 13, 2026

Reopening (there was nothing wrong with the PR, it was only assumed it wasn't necessary anymore)

@fedejeanne fedejeanne reopened this Jan 13, 2026
@laeubi @fedejeanne
Hide icons in chevron menu when preference is enabled eclipse-platfor…
f5546f7 
…m#3463

Fixes eclipse-platform#3463

Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
@fedejeanne fedejeanne force-pushed the fix-1331477-485750151-b3810fb9-7c32-4159-81c5-cad6806a87c1 branch from bad4685 to f5546f7 Compare January 13, 2026 11:11
@fedejeanne
Copy link
Member

fedejeanne commented Jan 13, 2026

Failing test is unrelated:

@fedejeanne fedejeanne merged commit 22d8db1 into eclipse-platform:master Jan 13, 2026
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fedejeanne fedejeanne fedejeanne approved these changes

@BeckerWdf BeckerWdf BeckerWdf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Icons are visible in the chevron even if the preference "Hide icons" is set to true

3 participants

@laeubi @fedejeanne @BeckerWdf