disable redrawing when setting visible region to prevent flickering #3457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iloveeclipse
approved these changes
Oct 30, 2025
iloveeclipse
previously requested changes
Oct 30, 2025
...eclipse.jface.text/projection/org/eclipse/jface/text/source/projection/ProjectionViewer.java
Outdated
Show resolved
Hide resolved
danthe1st
force-pushed
the
set-visible-region-flickering
branch
2 times, most recently
from
c46953f to
bac8d3d
Compare
danthe1st
force-pushed
the
set-visible-region-flickering
branch
from
bac8d3d to
a2e088f
Compare
3 tasks
danthe1st
force-pushed
the
set-visible-region-flickering
branch
from
a2e088f to
7f0ce1d
Compare
danthe1st
force-pushed
the
set-visible-region-flickering
branch
2 times, most recently
from
6d4731e to
0c8d2ab
Compare
Contributor
Author
|
(only rebased/updated copyright headers, still waiting for re-review) |
vogella
force-pushed
the
set-visible-region-flickering
branch
from
0c8d2ab to
0df6f52
Compare
vogella
approved these changes
Jan 12, 2026
Contributor
vogella
left a comment
vogella
left a comment
There was a problem hiding this comment.
The changes look good to me.
The logic correctly handles the redraw state and ensures the scroll position is maintained (or ignored if redraw was already disabled) using the TextViewer.setRedraw(boolean, int) API. The try...finally block ensures that redrawing is always restored.
Also, thanks for updating the copyright year.
Contributor
|
Thanks @danthe1st |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
setVisibleRegionis repeatedly called with projection regions enabled, it first expands everything outside of the old visible region and then collapses everything inside the new visible region. This can result in Eclipse showing unwanted text for a fraction of a second.Without this change:
Screencast_20251026_113947.webm
With this change:
Screencast_20251026_114117.webm
(I made the recordings with eclipse-jdt/eclipse.jdt.ui#2302 active to get the visible regions logic in JDT)
I don't think an automated test is reasonable for this but I can try to provide a way to reproduce this manually without JDT if necessary.