Skip to content

Use SubMonintor in CheckConditionsContext#2574

Open
vogella wants to merge 2 commits intoeclipse-platform:masterfrom
vogella:submonitor-checkconditionscontext
Open

Use SubMonintor in CheckConditionsContext#2574
vogella wants to merge 2 commits intoeclipse-platform:masterfrom
vogella:submonitor-checkconditionscontext

Conversation

@vogella
Copy link
Contributor

@vogella vogella commented Dec 3, 2024

done() call not necessary here and convert can also handle null. Also split will also check for cancellation so the additional cancellation check is not necessary.

See https://www.eclipse.org/articles/Article-Progress-Monitors/article.html

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Test Results

 3 024 files  ±0   3 024 suites  ±0   2h 18m 0s ⏱️ + 1m 16s
 8 234 tests ±0   7 986 ✅ ±0  248 💤 ±0  0 ❌ ±0 
23 526 runs  ±0  22 735 ✅ ±0  791 💤 ±0  0 ❌ ±0 

Results for commit 2b4aea3. ± Comparison against base commit 89a19bf.

♻️ This comment has been updated with latest results.

@vogella vogella force-pushed the submonitor-checkconditionscontext branch from 90827ad to 0ebc1eb Compare December 4, 2024 06:39
@vogella vogella force-pushed the submonitor-checkconditionscontext branch from 0ebc1eb to 36b8bf4 Compare December 6, 2024 10:38
@vogella vogella force-pushed the submonitor-checkconditionscontext branch from 36b8bf4 to ccccbca Compare January 14, 2025 10:51
@vogella vogella force-pushed the submonitor-checkconditionscontext branch from ccccbca to 96cd020 Compare November 14, 2025 00:34
@vogella vogella force-pushed the submonitor-checkconditionscontext branch from 96cd020 to edeaad0 Compare December 17, 2025 15:53
@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ltk.core.refactoring/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 19d5a11b7b45fdbf0d6617f6762b79e2833994d6 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Wed, 17 Dec 2025 16:00:01 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/bundles/org.eclipse.ltk.core.refactoring/META-INF/MANIFEST.MF b/bundles/org.eclipse.ltk.core.refactoring/META-INF/MANIFEST.MF
index a4fdac38f2..9f0f659919 100644
--- a/bundles/org.eclipse.ltk.core.refactoring/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ltk.core.refactoring/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Automatic-Module-Name: org.eclipse.ltk.core.refactoring
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ltk.core.refactoring; singleton:=true
-Bundle-Version: 3.15.100.qualifier
+Bundle-Version: 3.15.200.qualifier
 Bundle-Activator: org.eclipse.ltk.internal.core.refactoring.RefactoringCorePlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
-- 
2.52.0

Further information are available in Common Build Issues - Missing version increments.

@vogella vogella force-pushed the submonitor-checkconditionscontext branch from f3ee6cf to b03721b Compare January 12, 2026 09:23
@vogella
Copy link
Contributor Author

vogella commented Jan 12, 2026

@ptziegler can you review?

@vogella vogella force-pushed the submonitor-checkconditionscontext branch from b03721b to dd78c37 Compare January 16, 2026 09:13
vogella and others added 2 commits February 26, 2026 11:40
done() call not necessary here and convert can also handle null.  Also
split will also check for cancellation so the additional cancellation
check is not necessary.

See https://www.eclipse.org/articles/Article-Progress-Monitors/article.html
@vogella vogella force-pushed the submonitor-checkconditionscontext branch from dd78c37 to 2b4aea3 Compare February 26, 2026 10:40
@vogella
Copy link
Contributor Author

vogella commented Feb 26, 2026

Planning to merge for next release once master opens up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants