Skip to content

[Gtk4] Paint before child snapshot in Display snapshotDrawProc#3299

Merged
akurtakov merged 1 commit into
eclipse-platform:masterfrom
akurtakov:master
May 12, 2026
Merged

[Gtk4] Paint before child snapshot in Display snapshotDrawProc#3299
akurtakov merged 1 commit into
eclipse-platform:masterfrom
akurtakov:master

Conversation

@akurtakov
Copy link
Copy Markdown
Member

Fixes JFace Forms rendering.

@akurtakov
Copy link
Copy Markdown
Member Author

Before:
image

After:
image

@akurtakov
Copy link
Copy Markdown
Member Author

akurtakov commented May 12, 2026

I plan to merge this one (as it affects Gtk 4 only) despite the misplaced buttons (they move to the correct place on resize) as before this patch nothing is visible at all.

@github-actions
Copy link
Copy Markdown
Contributor

Test Results (linux)

   94 files  ±0     94 suites  ±0   14m 6s ⏱️ -1s
4 597 tests ±0  4 373 ✅ ±0  224 💤 ±0  0 ❌ ±0 
3 383 runs  ±0  3 308 ✅ ±0   75 💤 ±0  0 ❌ ±0 

Results for commit ccc0ed0. ± Comparison against base commit c5244c1.

@akurtakov akurtakov self-assigned this May 12, 2026
Copy link
Copy Markdown
Contributor

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this is related to #2819 which shows GTK4 doing custom drawing under widgets instead of over them.

@akurtakov akurtakov merged commit f33b79e into eclipse-platform:master May 12, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants