Skip to content

[Win] Enabled Image+Text button ignores alignment #3277 #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmssngr wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −8
Open

[Win] Enabled Image+Text button ignores alignment #3277 #3282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Button.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1403,7 +1403,9 @@ LRESULT wmNotifyChild (NMHDR hdr, long wParam, long lParam) {
gc.dispose ();
}

left += isRadioOrCheck() ? radioOrCheckTextPadding : 0;
left += isRadioOrCheck()
? radioOrCheckTextPadding
: image != null ? MARGIN : 0;
RECT textRect = new RECT ();
OS.SetRect (textRect, left, nmcd.top + border, right, nmcd.bottom - border);

Expand All @@ -1420,13 +1422,7 @@ LRESULT wmNotifyChild (NMHDR hdr, long wParam, long lParam) {
}
OS.DrawText(nmcd.hdc, buffer, buffer.length, textRect, flags | OS.DT_CALCRECT);
OS.OffsetRect(textRect, 0, Math.max(0, (nmcd.bottom - textRect.bottom - border) / 2));
if (image != null) {
// The default button with an image doesn't respect the text alignment. So we do the same for styled buttons.
flags |= OS.DT_LEFT;
if (!isRadioOrCheck()) {
OS.OffsetRect(textRect, Math.max(MARGIN, (right - textRect.right) / 2 + 1), 0);
}
} else if ((style & SWT.LEFT) != 0) {
if ((style & SWT.LEFT) != 0) {
flags |= OS.DT_LEFT;
} else if ((style & SWT.RIGHT) != 0) {
flags |= OS.DT_RIGHT;
Expand Down
Loading