-
Notifications
You must be signed in to change notification settings - Fork 89
Dependency Updates #3579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency Updates #3579
Conversation
|
/request-license-review |
Workflow run (with attached summary files): |
37cfe4f to
8b54f57
Compare
|
@laeubi @merks bnd 7.2.0 has introduced a smaller range on junit. See https://github.com/bndtools/bnd/wiki/Changes-in-7.2.0#known-issues Regarding guava: The change was since we upgrade to guava 33 Those newly imported packages are because of guava requires
Open for suggestions, how to improve the situation. |
These should be optional, only required during compilation (in theory). |
|
I have created bndtools/bnd#7022 and will try to improve it. Would appreciate more feedback as soon as you find something. What is the timeline until you need this for the next eclipse release? So we can plan a 7.2.1 or 7.3.0 |
Guava depsI have added bndtools/bnd#7024 to adresse the Guava Dependencies by making them optional. Let me more if you discover more packages which should be optional. Regarding JUnit:I am a bit unsure what to do: bnd (biz.aQute.tester.junit-platform) has a Problem with JUnit starting 1.13 (bndtools/bnd#6651) So currently bnd osgi tests (or projects using it) need max. JUnit BOM 5.12.2 (or otherwise tests won't be discovered). I have a PR waiting for review for this ( bndtools/bnd#7000 ) but I got help from copilot since I am not familar with bnd tester stuff. |
8b54f57 to
69d3574
Compare
|
/request-license-review |
Thanks for your responsiveness during the holiday season. 👼 There's plenty of time. The release cycle is just started with M1 due this Friday. In any case, we generally wait for the reviews to finish and there are a bunch of them that require manual attention, e.g., https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/25362 So those will be stalled until well into January. The 2026-03 (4.39) release isn't until March so definitely plenty of time. Don't feel pressured!! |
I actually have no clue how Eclipse is using this. We have this in the target platform. https://repo.maven.apache.org/maven2/org/junit/platform/junit-platform-commons/1.14.1/ The automated processes generally update dependencies within a few hours of them being available in Maven Central so not being able to update this junit bundle is a general problem for the Platform. |
Yes since bndtools also pulls in Eclipse P2 for dependencies this caused problems as soon as the Eclipse's JUnit was higher than what bnd support. That was the reason for the small range I guess, so that bnd does not run into issues when we update Eclipse P2 (currently on 2023-12 as a baseline). Anyway, we have the JUnit topic on our radar for the near future, since it is causing headaches for all bnd consumers who are using bnd's junit test support. Maybe bndtools/bnd#7000 is a first step |
to avoid problems for consumers of bnd (like Eclipse who are on higher JUnit version eclipse-platform/eclipse.platform.releng.aggregator#3579) Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
to avoid problems for consumers of bnd (like Eclipse who are on higher JUnit version eclipse-platform/eclipse.platform.releng.aggregator#3579) Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
to avoid problems for consumers of bnd (like Eclipse who are on higher JUnit version eclipse-platform/eclipse.platform.releng.aggregator#3579) Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
|
@merks bndtools/bnd#7024 is ready regarding Guava / Errorprone / JUnit. In the PR description I also printed the MANIFEST.MF of the new jars. Appreciate some feedback. |
69d3574 to
119f959
Compare
119f959 to
35df160
Compare
to avoid problems for consumers of bnd (like Eclipse who are on higher JUnit version eclipse-platform/eclipse.platform.releng.aggregator#3579) Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
to avoid problems for consumers of bnd (like Eclipse who are on higher JUnit version eclipse-platform/eclipse.platform.releng.aggregator#3579) Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
Eliminated org.jspecify.jspecify and com.google.errorprone.annotations from the build and import configurations as they are no longer required. Updated Import-Package to explicitly exclude these packages. Signed-off-by: Christoph Rueger <chrisrueger@gmail.com> make errorprone / guava.failureaccess private Remove packages from Import-Package for com.google.common.util.concurrent.internal and com.google.errorprone.annotations. Signed-off-by: Christoph Rueger <chrisrueger@gmail.com> make org.junit.platform resolution:=optional, to avoid problems for consumers of bnd (like Eclipse who are on higher JUnit version eclipse-platform/eclipse.platform.releng.aggregator#3579) Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
Eliminated org.jspecify.jspecify and com.google.errorprone.annotations from the build and import configurations as they are no longer required. Updated Import-Package to explicitly exclude these packages. Signed-off-by: Christoph Rueger <chrisrueger@gmail.com> make errorprone / guava.failureaccess private Remove packages from Import-Package for com.google.common.util.concurrent.internal and com.google.errorprone.annotations. Signed-off-by: Christoph Rueger <chrisrueger@gmail.com> make org.junit.platform resolution:=optional, to avoid problems for consumers of bnd (like Eclipse who are on higher JUnit version eclipse-platform/eclipse.platform.releng.aggregator#3579) Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
|
@merks FYI bnd 7.2.1-RC1 is available: https://github.com/bndtools/bnd/wiki/Changes-in-7.2.1 Not sure what you exactly need for testing. Maybe the jars relevant for you could be:
Feedback is appreciated, maybe here. |





The content of the target
eclipse-sdk-prereqs.targetwas updatedPlease review the changes and merge if appropriate, or cherry pick individual updates.
The following maven artifacts have been updated:
biz.aQute.bnd:aQute.libg:jar:7.1.0has been updated to version7.2.0biz.aQute.bnd:biz.aQute.bnd.annotation:jar:7.1.0has been updated to version7.2.0biz.aQute.bnd:biz.aQute.bnd.embedded-repo:jar:7.1.0has been updated to version7.2.0biz.aQute.bnd:biz.aQute.bnd.util:jar:7.1.0has been updated to version7.2.0biz.aQute.bnd:biz.aQute.bndlib:jar:7.1.0has been updated to version7.2.0biz.aQute.bnd:biz.aQute.repository:jar:7.1.0has been updated to version7.2.0biz.aQute.bnd:biz.aQute.resolve:jar:7.1.0has been updated to version7.2.0biz.aQute.bnd:biz.aQute.tester:jar:7.1.0has been updated to version7.2.0org.bndtools:bndtools.api:jar:7.1.0has been updated to version7.2.0org.bndtools:bndtools.jareditor:jar:7.1.0has been updated to version7.2.0org.bndtools:org.bndtools.headless.build.manager:jar:7.1.0has been updated to version7.2.0org.bndtools:org.bndtools.headless.build.plugin.gradle:jar:7.1.0has been updated to version7.2.0org.bndtools:org.bndtools.templates.template:jar:7.1.0has been updated to version7.2.0org.bndtools:org.bndtools.versioncontrol.ignores.manager:jar:7.1.0has been updated to version7.2.0org.bndtools:org.bndtools.versioncontrol.ignores.plugin.git:jar:7.1.0has been updated to version7.2.0