Make spyPart shortcut attribute optional#2326
Open
vogella wants to merge 1 commit into
Open
Conversation
vogella
force-pushed
the
spy-processor-optional-shortcut
branch
2 times, most recently
from
e5ecc06 to
84b6d63
Compare
The shortcut attribute on the org.eclipse.pde.spy.core.spyPart extension point is not declared as required in its schema, but SpyProcessor would NPE when a contribution omitted it (keySequence.equals in bindSpyKeyBinding). Skip key-binding registration when no shortcut is provided so a spy can opt into discoverability via the spy stack toolbar without claiming a global keystroke.
vogella
force-pushed
the
spy-processor-optional-shortcut
branch
2 times, most recently
from
ac39ed4 to
86474d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
shortcutattribute on theorg.eclipse.pde.spy.core.spyPartextension point is not declared as required in its schema, butSpyProcessorwould NPE when a contribution omitted it (keySequence.equalsinbindSpyKeyBinding). This skips key-binding registration when no shortcut is provided, so a spy can opt into discoverability via the spy stack toolbar without claiming a global keystroke.Planned for 4.41