feat(admin): improve user management page #1847
Open
gnugomez wants to merge 7 commits into
Open
Conversation
Assisted-By: anthropic:claude-opus-4-7[1m]
… update Assisted-By: github:claude-opus-4.6, github:claude-sonnet-4.6, anthropic:claude-opus-4-7[1m]
gnugomez
requested review from
autumnfound and
netomi
and removed request for
netomi
netomi
reviewed
May 19, 2026
| } | ||
| var json = user.toUserJson(); | ||
| var serverUrl = UrlUtil.getBaseUrl(); | ||
| json.setRole(user.getRole()); |
Contributor
There was a problem hiding this comment.
if the role is not part anymore of the User object, the frontend will not be able to check if the current user is an admin I guess?
Member
Author
There was a problem hiding this comment.
UserData::toUserJson is already setting the role, here we're just adding it twice
autumnfound
reviewed
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1786
Assisted-By: github:claude-opus-4.6, github:claude-sonnet-4.6, anthropic:claude-opus-4-7[1m]