Skip to content

Remove invalid line breakpoints on non-breakpointable locations on Edit #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SougandhS wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −1
Draft

Remove invalid line breakpoints on non-breakpointable locations on Edit #810

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd76a60
Remove invalid line breakpoints on non-breakpointable locations on Edit
SougandhS Nov 17, 2025
c62ba81
Exclude watchpoint
SougandhS Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/BreakpointMarkerUpdater.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2006, 2021 IBM Corporation and others.
* Copyright (c) 2006, 2025 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -136,6 +136,11 @@ public boolean updateMarker(IMarker marker, IDocument document, Position positio
if (loc.getLocationType() != ValidBreakpointLocationLocator.LOCATION_FIELD && breakpoint instanceof IJavaWatchpoint) {
return false;
}

if (loc.getLocationType() == ValidBreakpointLocationLocator.LOCATION_FIELD && breakpoint instanceof JavaLineBreakpoint
&& !(breakpoint instanceof IJavaWatchpoint)) {
return false;
}
int line = loc.getLineLocation();
//if the line number is already good, perform no marker updating
if(MarkerUtilities.getLineNumber(marker) == line) {
Expand Down
Loading