Changed analytics API. Related to #5119 #5122
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+16
to
+18
| .config(($sceDelegateProvider) => { | ||
| $sceDelegateProvider.resourceUrlWhitelist(['self', 'https://www.googletagmanager.com/gtag/js**']); | ||
| }) |
Check warning
Code scanning / CodeQL
Missing explicit dependency injection Warning
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 7 months ago
To fix the issue, we will replace the implicit dependency injection in the function on line 16 with explicit annotations. This involves wrapping the dependency name ($sceDelegateProvider) and the function in an array. The array's first element will be the dependency name as a string, and the second element will be the function itself. This ensures that the dependency injection works correctly even after minification.
Suggested changeset
1
components/ui/platform-core/src/main/resources/META-INF/dirigible/platform-core/ui/platform/view.js
| @@ -15,5 +15,5 @@ | ||
| .constant('clientOS', { isMac: () => navigator.userAgent.includes('Mac') }) | ||
| .config(($sceDelegateProvider) => { | ||
| .config(['$sceDelegateProvider', ($sceDelegateProvider) => { | ||
| $sceDelegateProvider.resourceUrlWhitelist(['self', 'https://www.googletagmanager.com/gtag/js**']); | ||
| }) | ||
| }]) | ||
| .factory('baseHttpInterceptor', () => { |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the way we set the Google analytics script.
Now the env var
DIRIGIBLE_BRANDING_ANALYTICSshould contain the GTag ID and in order to enable analytics for a shell, perspective, view, etc. the user should include theanalyticstag just before thethemetag.What issues does this PR fix or reference?
#5119