Skip to content

Conversation

@juliapampus
Copy link
Contributor

What this PR changes/adds

Explains how to use DSP for contract termination.

Why it does that

Address community requests, such as #17.

Further notes

This PR raises requirements for the specification document:

  • Add leftOperand for Agreement

Related discussion in Tractus-X project: eclipse-tractusx/tractusx-edc#1392 (comment)

Linked Issue(s)

--

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

Copy link
Contributor

@arnoweiss arnoweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the writeup, a couple of notes:

  1. I'd suggest to stick closer to the problem. If the document is called "Contract Termination", considerations on other things associated with contracts/agreements (amendments etc) should be left out.
  2. Let's consider how to link this work to the other best practices. When boiling it down, this document suggests a Policy Profile for contract termination, doesn't it?


There, the policies represent parts of the paper contract like contextual attributes (duration, contract reference) or organizational attributes (business partner ID, location of the headquarters, membership status).

### Summary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same criticism as before. I don't think there's value in being this specific - especially in the later stages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've shortened this section. As this is a best practices document, I would be in favour of having some additional explaining information - especially as we know the most frequent discussion points. However, I agree that we should not make unnecessary assumptions or statements.

Is the Catena-X example okay?

@juliapampus juliapampus force-pushed the feat/contract-revocation branch from 5339723 to 1353233 Compare October 23, 2025 15:00
@juliapampus
Copy link
Contributor Author

thanks for the writeup, a couple of notes:

  1. I'd suggest to stick closer to the problem. If the document is called "Contract Termination", considerations on other things associated with contracts/agreements (amendments etc) should be left out.
  2. Let's consider how to link this work to the other best practices. When boiling it down, this document suggests a Policy Profile for contract termination, doesn't it?

Thanks for your comments! I have moved the text to the profile section.

@juliapampus juliapampus requested a review from arnoweiss October 23, 2025 15:01
Copy link
Contributor

@arnoweiss arnoweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One example could be clarified a bit. Overall, this is a lean, viable best practice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants