-
Notifications
You must be signed in to change notification settings - Fork 4
feat: contract termination #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: contract termination #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the writeup, a couple of notes:
- I'd suggest to stick closer to the problem. If the document is called "Contract Termination", considerations on other things associated with contracts/agreements (amendments etc) should be left out.
- Let's consider how to link this work to the other best practices. When boiling it down, this document suggests a Policy Profile for contract termination, doesn't it?
legal/contract-termination.md
Outdated
|
|
||
| There, the policies represent parts of the paper contract like contextual attributes (duration, contract reference) or organizational attributes (business partner ID, location of the headquarters, membership status). | ||
|
|
||
| ### Summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same criticism as before. I don't think there's value in being this specific - especially in the later stages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've shortened this section. As this is a best practices document, I would be in favour of having some additional explaining information - especially as we know the most frequent discussion points. However, I agree that we should not make unnecessary assumptions or statements.
Is the Catena-X example okay?
Co-authored-by: Arno Weiß <86715435+arnoweiss@users.noreply.github.com>
5339723 to
1353233
Compare
Thanks for your comments! I have moved the text to the profile section. |
arnoweiss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One example could be clarified a bit. Overall, this is a lean, viable best practice!
What this PR changes/adds
Explains how to use DSP for contract termination.
Why it does that
Address community requests, such as #17.
Further notes
This PR raises requirements for the specification document:
leftOperandforAgreementRelated discussion in Tractus-X project: eclipse-tractusx/tractusx-edc#1392 (comment)
Linked Issue(s)
--
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.