Skip to content

Fix one disabled Test - fix external #5 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stbischof merged 1 commit into from
Mar 24, 2025
Merged

Fix one disabled Test - fix external #5 #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions ...sqltranspiler/src/test/java/org/eclipse/daanse/sql/guard/jsqltranspiler/SqlGuardTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@ void testInnerJoin(@InjectService SqlGuardFactory sqlGuardFactory) throws Except
}

@Test
@Disabled
void testInnerJoin1(@InjectService SqlGuardFactory sqlGuardFactory) throws Exception {
DatabaseCatalog databaseCatalog = schemaWithTwoTableTwoCol();

Expand Down Expand Up @@ -268,28 +267,16 @@ void testGroupAggregation(@InjectService SqlGuardFactory sqlGuardFactory) throws

assertThrows(UnresolvableObjectsGuardException.class,
() -> guard.guard(String.format(SQL_WITH_HAVING_WRONG_TABLE, agg, agg)));
// TODO "select avg(foo1.id) from foo group by foo.name")" with any aggregation use wrong table
// "foo1". we have foo table only
// assertThrows(RuntimeException.class, () -> guard.guard("select avg(foo1.id) from foo group by
// foo.name"));

result = guard.guard(String.format(SQL_WITH_HAVING1, agg));
assertEquals(String.format(SQL_WITH_HAVING1_EXPECTED, agg), result);

assertThrows(UnresolvableObjectsGuardException.class,
() -> guard.guard(String.format(SQL_WITH_HAVING_WRONG_TABLE1, agg)));
// TODO select sum(foo.id) from foo group by foo.name having foo1.name = 'tets' with any aggregation
// use wrong table "foo1". we have "foo" table only
// assertThrows(RuntimeException.class, () -> guard.guard("select count(foo.id) from foo group by
// foo.name having foo1.name = 'tets'"));

assertThrows(UnresolvableObjectsGuardException.class, () ->

guard.guard(String.format(SQL_WITH_HAVING_WRONG_COLUMN, agg)));
// TODO select sum(foo.id) from foo group by foo.name having foo.name1 = 'tets' we use wrong column
// name1. name1 ia absent. we have "name" column only
// assertThrows(RuntimeException.class, () -> guard.guard("select count(foo.id) from foo group by
// foo.name having foo.name1 = 'tets'"));

}
}
Expand Down
Loading