Update dependencies to get rid of form-data vulnerability #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcdumais-work
force-pushed
the
form-fetch-vulnerability
branch
2 times, most recently
from
098f24b to
040e5e5
Compare
marcdumais-work
changed the title
bhufmann
requested changes
Aug 21, 2025
Contributor
bhufmann
left a comment
bhufmann
left a comment
There was a problem hiding this comment.
After checking out and building the yarn.lock is updated. You need the revert the following change in the yarn.lock:
git diff
diff --git a/yarn.lock b/yarn.lock
index 90fa333..6ded88e 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -3877,7 +3877,7 @@ js-yaml@^3.10.0, js-yaml@^3.13.1, js-yaml@^3.14.1:
argparse "^1.0.7"
esprima "^4.0.0"
-"json-bigint@github:sidorares/json-bigint#2c0a5f896d7888e68e5f4ae3c7ea5cd42fd54473":
+json-bigint@sidorares/json-bigint#2c0a5f896d7888e68e5f4ae3c7ea5cd42fd54473:
version "1.0.0"
resolved "https://codeload.github.com/sidorares/json-bigint/tar.gz/2c0a5f896d7888e68e5f4ae3c7ea5cd42fd54473"
dependencies:
Update to get rid of this critical severity vulnerability. see: https://github.com/dependency-insights/npm/form-data/4.0.0/security?query=org%3Aeclipse-cdt-cloud Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work
force-pushed
the
form-fetch-vulnerability
branch
from
040e5e5 to
a593b9f
Compare
Contributor
Author
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Update to get rid of this critical severity vulnerability.
see:
https://github.com/dependency-insights/npm/form-data/4.0.0/security?query=org%3Aeclipse-cdt-cloud
How to test
Confirm that CI passes. Optionally perform a "yarn why form-data" and confirm that the version pulled is not vulnerable. The version expected with this PR is:
form-data@4.0.4Note: there's a small chance that we will have problem when we next try to publish, since we updated
@vscode/vsceandovsx. There is unfortunately no easy way to test publishing at this time as part of the PR. If that happens, we can correct with a follow-up.Follow-ups
N/A
Review checklist