feat: add third-party block support #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add methods to create and inspect third party blocks: - `Biscuit::append_third_party` for creating biscuits with third party blocks - `Biscuit::external_key` for retrieving external keys from blocks - Add unit tests covering third party block functionality
Closed
Contributor
|
Neat! A good addition would be to exposing support for requests, since in most cases, we don’t want to transmit the whole token to the third-party. |
Contributor
|
You’ll need to sign the Eclipse Contributor Agreement: https://github.com/eclipse-biscuit/biscuit-rust/blob/main/CONTRIBUTING.md#eclipse-contributor-agreement |
Contributor
Author
I’ve updated the code to include |
Contributor
|
I’m sorry, I missed your answer. This looks great! |
divarvel
approved these changes
Sep 19, 2025
Contributor
|
I’ll add pyi bindings myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add methods to create and inspect third party blocks:
Biscuit::third_party_requestfor creating third party requestsThirdPartyRequest::create_blockfor creating third party blocksBiscuit::append_third_partyfor creating biscuits with third party blocksBiscuit::external_keyfor retrieving external keys from blocks