Change deleteSubmodelReferenceByIdAasRepository to return NO_CONTENT #961
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for implementing this fix. As you can see from the failed pipelines, a few minor changes are also needed in tests where this endpoint is used. Would you be so kind to also adapt the expected values in the tests so that they run through as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description of Changes
Changed the return code for endpoint DELETE '/shells/{aasIdentifier}/submodel-refs/{submodelIdentifier}' to 204 (NO_CONTENT)
Related Issue
#949
BaSyx Configuration for Testing
AAS Files Used for Testing
Additional Information
Please ensure that you have tested your changes thoroughly before submitting the pull request.