-
Notifications
You must be signed in to change notification settings - Fork 64
Adds BaSyx Profile to all Components #952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request introduces a new BaSyx-specific profile (BASYXSERVICESPECIFICATION_SSP_001) across all BaSyx service components to enable identification of BaSyx infrastructure implementations. The profile is added to service description endpoints following the IDTA specification for AAS service profiles.
Changes:
- Added new
BASYXSERVICESPECIFICATION_SSP_001profile enum and URI to the common Profile enum - Extended profile declarations for five repository/server services (AAS Repository, Submodel Repository, Concept Description Repository, AASX File Server, AAS Discovery Service)
- Updated AAS Registry and Submodel Registry to programmatically include the BaSyx profile in their description responses
- Modified OpenAPI specifications for both registries to include the new profile in the ServiceDescription schema
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| basyx.common/basyx.http/src/main/java/org/eclipse/digitaltwin/basyx/http/description/Profile.java | Adds the new BASYXSERVICESPECIFICATION_SSP_001 enum constant with its URI |
| basyx.submodelrepository/basyx.submodelrepository-http/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/http/SubmodelRepositoryServiceDescriptionConfiguration.java | Adds BaSyx profile to Submodel Repository service profiles |
| basyx.conceptdescriptionrepository/basyx.conceptdescriptionrepository-http/src/main/java/org/eclipse/digitaltwin/basyx/conceptdescriptionrepository/http/ConceptDescriptionRepositoryServiceDescriptionConfiguration.java | Adds BaSyx profile to Concept Description Repository service profiles |
| basyx.aasxfileserver/basyx.aasxfileserver-http/src/main/java/org/eclipse/digitaltwin/basyx/aasxfileserver/http/AASXFileServerDescriptionConfiguration.java | Adds BaSyx profile to AASX File Server service profiles |
| basyx.aasrepository/basyx.aasrepository-http/src/main/java/org/eclipse/digitaltwin/basyx/aasrepository/http/AasRepositoryServiceDescriptionConfiguration.java | Adds BaSyx profile to AAS Repository service profiles |
| basyx.aasdiscoveryservice/basyx.aasdiscoveryservice-http/src/main/java/org/eclipse/digitaltwin/basyx/aasdiscoveryservice/http/AasDiscoveryServiceDescriptionConfiguration.java | Adds BaSyx profile to AAS Discovery Service profiles |
| basyx.aasregistry/basyx.aasregistry-service/src/main/java/org/eclipse/digitaltwin/basyx/aasregistry/service/api/BasyxDescriptionApiDelegate.java | Programmatically adds BaSyx profile to AAS Registry description response |
| basyx.submodelregistry/basyx.submodelregistry-service/src/main/java/org/eclipse/digitaltwin/basyx/submodelregistry/service/api/BasyxDescriptionApiDelegate.java | Programmatically adds BaSyx profile to Submodel Registry description response |
| basyx.aasregistry/open-api/patch-base-extensions.yaml | Updates OpenAPI schema to include BaSyx profile in ServiceDescription enum and varnames |
| basyx.submodelregistry/open-api/patch-base-extensions.yaml | Updates OpenAPI schema to include BaSyx profile in ServiceDescription enum and varnames |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../java/org/eclipse/digitaltwin/basyx/aasregistry/service/api/BasyxDescriptionApiDelegate.java
Outdated
Show resolved
Hide resolved
.../org/eclipse/digitaltwin/basyx/submodelregistry/service/api/BasyxDescriptionApiDelegate.java
Outdated
Show resolved
Hide resolved
.../java/org/eclipse/digitaltwin/basyx/aasregistry/service/api/BasyxDescriptionApiDelegate.java
Outdated
Show resolved
Hide resolved
....common/basyx.http/src/main/java/org/eclipse/digitaltwin/basyx/http/description/Profile.java
Outdated
Show resolved
Hide resolved
…eclipse/digitaltwin/basyx/aasregistry/service/api/BasyxDescriptionApiDelegate.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…eclipse/digitaltwin/basyx/aasregistry/service/api/BasyxDescriptionApiDelegate.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…basyx/http/description/Profile.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/java/org/eclipse/digitaltwin/basyx/submodelregistry/service/api/BasyxDescriptionApiDelegate.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
aaronzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description of Changes
This pull request introduces the new
BASYXSERVICESPECIFICATION_SSP_001profile across multiple BaSyx services, ensuring consistent support and representation in both code and OpenAPI specifications. The main changes involve extending profile declarations, updating enums, and modifying API/service descriptions to include this new profile.Profile support extension
Added
Profile.BASYXSERVICESPECIFICATION_SSP_001to the profile declarations for AASX File Server, AAS Discovery Service, AAS Repository, Concept Description Repository, and Submodel Repository by updating their respective configuration classes (AASXFileServerDescriptionConfiguration.java,AasDiscoveryServiceDescriptionConfiguration.java,AasRepositoryServiceDescriptionConfiguration.java,ConceptDescriptionRepositoryServiceDescriptionConfiguration.java,SubmodelRepositoryServiceDescriptionConfiguration.java). [1] [2] [3] [4] [5]Updated the
Profileenum inProfile.javato define the newBASYXSERVICESPECIFICATION_SSP_001profile and its associated URI.API and service description updates
Modified the
setValuesmethod inBasyxDescriptionApiDelegate.javafor both AAS Registry and Submodel Registry services to always includeProfilesEnum.BASYXSERVICESPECIFICATION_SSP_001in the list of supported profiles. [1] [2]Added import of
ProfiletoBasyxDescriptionApiDelegate.javato support usage of the new profile.OpenAPI specification enhancements
ServiceDescriptionschema. [1] [2]Related Issue
closes #950