Skip to content

Conversation

@FriedJannik
Copy link
Member

Description of Changes

This pull request introduces the new BASYXSERVICESPECIFICATION_SSP_001 profile across multiple BaSyx services, ensuring consistent support and representation in both code and OpenAPI specifications. The main changes involve extending profile declarations, updating enums, and modifying API/service descriptions to include this new profile.

Profile support extension

  • Added Profile.BASYXSERVICESPECIFICATION_SSP_001 to the profile declarations for AASX File Server, AAS Discovery Service, AAS Repository, Concept Description Repository, and Submodel Repository by updating their respective configuration classes (AASXFileServerDescriptionConfiguration.java, AasDiscoveryServiceDescriptionConfiguration.java, AasRepositoryServiceDescriptionConfiguration.java, ConceptDescriptionRepositoryServiceDescriptionConfiguration.java, SubmodelRepositoryServiceDescriptionConfiguration.java). [1] [2] [3] [4] [5]

  • Updated the Profile enum in Profile.java to define the new BASYXSERVICESPECIFICATION_SSP_001 profile and its associated URI.

API and service description updates

  • Modified the setValues method in BasyxDescriptionApiDelegate.java for both AAS Registry and Submodel Registry services to always include ProfilesEnum.BASYXSERVICESPECIFICATION_SSP_001 in the list of supported profiles. [1] [2]

  • Added import of Profile to BasyxDescriptionApiDelegate.java to support usage of the new profile.

OpenAPI specification enhancements

  • Updated OpenAPI patch files for both AAS Registry and Submodel Registry to add the new profile URI and enum variable name to the ServiceDescription schema. [1] [2]

Related Issue

closes #950

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request introduces a new BaSyx-specific profile (BASYXSERVICESPECIFICATION_SSP_001) across all BaSyx service components to enable identification of BaSyx infrastructure implementations. The profile is added to service description endpoints following the IDTA specification for AAS service profiles.

Changes:

  • Added new BASYXSERVICESPECIFICATION_SSP_001 profile enum and URI to the common Profile enum
  • Extended profile declarations for five repository/server services (AAS Repository, Submodel Repository, Concept Description Repository, AASX File Server, AAS Discovery Service)
  • Updated AAS Registry and Submodel Registry to programmatically include the BaSyx profile in their description responses
  • Modified OpenAPI specifications for both registries to include the new profile in the ServiceDescription schema

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
basyx.common/basyx.http/src/main/java/org/eclipse/digitaltwin/basyx/http/description/Profile.java Adds the new BASYXSERVICESPECIFICATION_SSP_001 enum constant with its URI
basyx.submodelrepository/basyx.submodelrepository-http/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/http/SubmodelRepositoryServiceDescriptionConfiguration.java Adds BaSyx profile to Submodel Repository service profiles
basyx.conceptdescriptionrepository/basyx.conceptdescriptionrepository-http/src/main/java/org/eclipse/digitaltwin/basyx/conceptdescriptionrepository/http/ConceptDescriptionRepositoryServiceDescriptionConfiguration.java Adds BaSyx profile to Concept Description Repository service profiles
basyx.aasxfileserver/basyx.aasxfileserver-http/src/main/java/org/eclipse/digitaltwin/basyx/aasxfileserver/http/AASXFileServerDescriptionConfiguration.java Adds BaSyx profile to AASX File Server service profiles
basyx.aasrepository/basyx.aasrepository-http/src/main/java/org/eclipse/digitaltwin/basyx/aasrepository/http/AasRepositoryServiceDescriptionConfiguration.java Adds BaSyx profile to AAS Repository service profiles
basyx.aasdiscoveryservice/basyx.aasdiscoveryservice-http/src/main/java/org/eclipse/digitaltwin/basyx/aasdiscoveryservice/http/AasDiscoveryServiceDescriptionConfiguration.java Adds BaSyx profile to AAS Discovery Service profiles
basyx.aasregistry/basyx.aasregistry-service/src/main/java/org/eclipse/digitaltwin/basyx/aasregistry/service/api/BasyxDescriptionApiDelegate.java Programmatically adds BaSyx profile to AAS Registry description response
basyx.submodelregistry/basyx.submodelregistry-service/src/main/java/org/eclipse/digitaltwin/basyx/submodelregistry/service/api/BasyxDescriptionApiDelegate.java Programmatically adds BaSyx profile to Submodel Registry description response
basyx.aasregistry/open-api/patch-base-extensions.yaml Updates OpenAPI schema to include BaSyx profile in ServiceDescription enum and varnames
basyx.submodelregistry/open-api/patch-base-extensions.yaml Updates OpenAPI schema to include BaSyx profile in ServiceDescription enum and varnames

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

FriedJannik and others added 6 commits January 12, 2026 08:57
…eclipse/digitaltwin/basyx/aasregistry/service/api/BasyxDescriptionApiDelegate.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…eclipse/digitaltwin/basyx/aasregistry/service/api/BasyxDescriptionApiDelegate.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…basyx/http/description/Profile.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/java/org/eclipse/digitaltwin/basyx/submodelregistry/service/api/BasyxDescriptionApiDelegate.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Member

@aaronzi aaronzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FriedJannik FriedJannik merged commit a11c1ee into eclipse-basyx:main Jan 12, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Ticket] Create a BaSyx profile that is used in all description endpoints

2 participants