Skip to content

Harden DocumentParser against XXE attacks#354

Open
metsw24-max wants to merge 3 commits into
eclipse-aspectj:masterfrom
metsw24-max:documentparser-xxe-hardening
Open

Harden DocumentParser against XXE attacks#354
metsw24-max wants to merge 3 commits into
eclipse-aspectj:masterfrom
metsw24-max:documentparser-xxe-hardening

Conversation

@metsw24-max
Copy link
Copy Markdown

Implemented XML parser hardening in DocumentParser to prevent external entity resolution during AspectJ load-time definition parsing.

Changes

  • Enabled secure SAX parser processing
  • Disabled:
    • external general entities
    • external parameter entities
    • external DTD loading
  • Applied secure parser configuration to both SAXParserFactory and XMLReader
  • Added regression test coverage for malicious XML containing external entity references
  • Added evil.xml test fixture to validate secure parsing behavior

@kriegaex
Copy link
Copy Markdown
Contributor

kriegaex commented May 9, 2026

Just in case you are wondering why sometimes I comment or run workflows on your behalf, but am not committing or merging anything:

Please note my July 2024 message to the aspectj-users and aspectj-announce mailing lists regarding my situation as an AspectJ maintainer. Andy Clement has since returned to fixing issues and releasing updates, but he has very little time, so response times can be longer than you might expect. Nobody has yet offered to sponsor my work for this project, so I am still on hiatus until someone finally does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants