Skip to content

Use precalculated hasChecklists flag for checklist navigation item#9698

Open
manuelmeister wants to merge 6 commits into
ecamp:develfrom
manuelmeister:performance/prevent-checklist-request
Open

Use precalculated hasChecklists flag for checklist navigation item#9698
manuelmeister wants to merge 6 commits into
ecamp:develfrom
manuelmeister:performance/prevent-checklist-request

Conversation

@manuelmeister
Copy link
Copy Markdown
Member

With this we can save us an initial call to checklists.

@manuelmeister manuelmeister marked this pull request as draft May 6, 2026 16:02
Copy link
Copy Markdown
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only courses may use checklists, and not only checklists determine whether a camp is a course or not. Can we name this a little more neutrally, e.g. hasChecklists?

@manuelmeister manuelmeister added the deploy! Creates a feature branch deployment for this PR label May 6, 2026
@manuelmeister manuelmeister changed the title Use dynamically calculated isCourse flag for checklist navigation item Use calculated hasChecklists flag for checklist navigation item May 6, 2026
@manuelmeister manuelmeister changed the title Use calculated hasChecklists flag for checklist navigation item Use precalculated hasChecklists flag for checklist navigation item May 6, 2026
@manuelmeister manuelmeister temporarily deployed to feature-branch May 6, 2026 20:57 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Feature branch deployment ready!

Name Link
😎 Deployment https://pr9698.ecamp3.ch/
🔑 Login test@example.com / test
🕒 Last deployed at Tue May 12 2026 19:44:34 GMT+0200
🔨 Latest commit 139be1885391829384e98443486c66de922653f9
🔍 Latest deploy log https://github.com/ecamp/ecamp3/actions/runs/25751642688/job/75629695964
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Comment thread api/src/Entity/Camp.php
Comment thread api/src/State/ChecklistRemoveProcessor.php Outdated
Comment thread api/src/State/ChecklistRemoveProcessor.php
Comment thread api/migrations/dev-data/data.sql
@manuelmeister manuelmeister marked this pull request as ready for review May 12, 2026 12:03
@manuelmeister manuelmeister temporarily deployed to feature-branch May 12, 2026 12:06 — with GitHub Actions Inactive
@manuelmeister manuelmeister requested a review from a team May 12, 2026 12:23
@manuelmeister manuelmeister temporarily deployed to feature-branch May 12, 2026 17:43 — with GitHub Actions Inactive
@manuelmeister
Copy link
Copy Markdown
Member Author

Core Meeting Decision

We don't want a DB field. This could be solved with replacing the collection link with a array of iris (removing the ApiFilter on Checklist.php for camp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy! Creates a feature branch deployment for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants