Add an "ordered" option to hasMany attributes.#434
Open
spectras wants to merge 1 commit into
Open
Conversation
spectras
force-pushed
the
feature/ordered_many
branch
from
1c57a88 to
e0630d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty self-explaining. Allows doing:
When this option is set, the
ManyArraywill be dirty when its items have been re-ordered, even if the set of items is still the same (the test changes from testing whether each item was present in original to testing whether it was at the same place).Comes with a testcase.