Update get_trials_from_db.py #153
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inglesp
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
cleanup_dataset, which works post-scrape during data handling, is breaking due to bad date data. A date (not sure which trial yet) is showing up as202-04-30whichpd.to_datetimedoesn't like.If we can find the trial we might be able to make a good guess at what that date should be, but that is annoying and finnicky anyway. I'm comfortable, therefore, with using the built-in error handling in Pandas to coerce a broken date to a
NaT. A broken date might as well not exist for us so lets treat it as if that is the case.