Update versions #196
Open
Update versions #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparK-Cruz
reviewed
Oct 19, 2024
| @@ -0,0 +1,17 @@ | |||
| FROM php:7.4-cli | |||
Contributor
There was a problem hiding this comment.
Nice. Long time I don't check this repo.
Just make sure in case a php version goes unsupported (as in: no more security updates) it's a good idea to also raise the version to something secure and also test it with the latest version.
If we test the higher and lower limits we can be sure all versions in between will work.
That way in case a merchant is using an older version of PHP that has known CVEs we notify them (or ask their rep in merchant services to do so) so that they upgrade, no matter what the team lead says about supporting old versions! In case a team lead insists make them sign a document stating they will pay for the damages in case the merchant gets hacked, thank you! XD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the SDK dependencies