Skip to content

Rework diffusion models#191

Open
henrikjacobsenfys wants to merge 23 commits into
developfrom
delta-lorentz
Open

Rework diffusion models#191
henrikjacobsenfys wants to merge 23 commits into
developfrom
delta-lorentz

Conversation

@henrikjacobsenfys
Copy link
Copy Markdown
Member

@henrikjacobsenfys henrikjacobsenfys commented May 22, 2026

The changes are described here: #190

I'm missing some tests, but the code is more or less how I want it to be, so a review would be nice

@henrikjacobsenfys henrikjacobsenfys added [scope] enhancement Adds/improves features (major.MINOR.patch) [priority] medium Normal/default priority labels May 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

❌ Patch coverage is 88.22055% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.27%. Comparing base (fff0285) to head (636693c).

Files with missing lines Patch % Lines
...mics/sample_model/diffusion_model/delta_lorentz.py 90.49% 18 Missing and 5 partials ⚠️
...mple_model/diffusion_model/diffusion_model_base.py 79.38% 16 Missing and 4 partials ⚠️
src/easydynamics/analysis/fit_binding.py 0.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #191      +/-   ##
===========================================
- Coverage    98.42%   97.27%   -1.15%     
===========================================
  Files           50       51       +1     
  Lines         3175     3524     +349     
  Branches       576      649      +73     
===========================================
+ Hits          3125     3428     +303     
- Misses          26       62      +36     
- Partials        24       34      +10     
Flag Coverage Δ
integration 44.97% <35.33%> (-1.20%) ⬇️
unittests 97.16% <87.21%> (-1.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@henrikjacobsenfys henrikjacobsenfys marked this pull request as ready for review May 26, 2026 07:42
@henrikjacobsenfys henrikjacobsenfys added [priority] high Should be prioritized soon and removed [priority] medium Normal/default priority labels May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[priority] high Should be prioritized soon [scope] enhancement Adds/improves features (major.MINOR.patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider if DiffusionModel should store Q internally Make sure diffusion models generate the correct dependent parameters

1 participant