Unify minimizer category and switchable-selector API surface

.github/copilot-instructions.md

@@ -122,6 +122,25 @@
   tests, tutorials, docs). Use `git grep -n` because all contributors
   have Git; do not assume `rg` is installed. If `git grep` is
   unavailable, fall back to `find ... -type f` plus `grep -n`.
+- When asked to review a plan, save the review next to that plan using
+  `<plan-stem>_review-N.md`, where `N` is one greater than the highest
+  existing review number for that plan. For example,
+  `docs/dev/plans/background-refactor.md` is reviewed in
+  `docs/dev/plans/background-refactor_review-1.md`, then
+  `docs/dev/plans/background-refactor_review-2.md`. A reviewer must not
+  run tests, `pixi run fix`, `pixi run check`, or any other build or
+  verification command; reviews are static reads of code, plan, and
+  documentation only. Note in the review which checks were skipped so
+  the next implementer knows the gap.
+- Writing a review or a reply to a review does **not** require running
+  any formatter (`prettier`, `pixi run fix`, `ruff format`, …) or any
+  lint/check/test command on the review/reply file itself or any
+  surrounding documentation. Review and reply files are markdown-only,
+  written by hand, and committed as-is. Formatting passes happen later,
+  during implementation Phase 2 verification — not in the review cycle.
+  This rule applies to both `_review-N.md` and `_reply-N.md` files
+  regardless of where they live (`docs/dev/plans/`, `docs/dev/adrs/…/`,
+  etc.).
 - Each change is atomic and single-commit-sized: make one change,
   suggest the commit message, then stop and wait for confirmation.
 - When in doubt, ask.
@@ -222,3 +241,13 @@ When asked to create a plan:
   understand the benefit. Update it during implementation if extra
   approved changes become important enough to mention in the PR title or
   description.
+- When replying to a plan review, save the reply alongside the review.
+  Reviews live at `docs/dev/plans/<feature-name>_review-<N>.md`; the
+  matching reply goes to `docs/dev/plans/<feature-name>_reply-<N>.md`
+  (same slug, same number, swap `review` → `reply`). One reply file per
+  review file; do not bundle replies to multiple reviews into one
+  document. Structure the reply with one section per finding, each
+  containing a verdict (agree / disagree / partial), the action taken in
+  the plan, and a pointer to the affected plan section. After updating
+  the plan, also update the reply if a numbered step shifts so that
+  cross-references stay accurate.

AGENTS.md

@@ -0,0 +1,5 @@
+# Agent Instructions
+
+Follow
+[`.github/copilot-instructions.md`](.github/copilot-instructions.md) for
+this repository.

CLAUDE.md

@@ -0,0 +1 @@
+@.github/copilot-instructions.md

docs/dev/adrs/accepted/analysis-cif-fit-state.md

@@ -15,8 +15,8 @@ Analysis and fitting.
 ## Context
 
 `analysis/analysis.cif` already persists analysis configuration such as
-`_fitting.minimizer_type`, `_fitting.mode_type`, aliases, constraints,
-and active fit-mode settings. That configuration alone is not enough to
+`_minimizer.type`, `_fitting_mode.type`, aliases, constraints, and
+active fit-mode settings. That configuration alone is not enough to
 reopen a saved project and continue the same fit-result, plotting, and
 command-line workflow.
 
@@ -26,9 +26,9 @@ Analysis-owned fit state needs to persist:
 - pre-fit scalar snapshots for recovery workflows
 - compact status metadata for the latest saved fit projection
 - deterministic correlation summaries
-- Bayesian summary metadata and manifests for bulk array sidecars
-- plot-ready Bayesian caches so restored posterior displays do not need
-  to recompute on first use
+- minimizer-specific fit outputs on the active `_minimizer.*` category
+- per-parameter posterior summaries on `_fit_parameter`
+- large posterior arrays and plot caches in `analysis/results.h5`
 
 Committed model parameter values and uncertainties already persist in
 structure and experiment CIF files through the accepted free-flag CIF
@@ -41,13 +41,14 @@ projection. This ADR defines that narrower saved projection.
 
 ## Decision
 
-Persist analysis-owned fit state as explicit sibling categories in
-`analysis/analysis.cif`, with large Bayesian arrays stored in
+Persist analysis-owned fit state as explicit analysis categories in
+`analysis/analysis.cif`, with large posterior arrays stored in
 `analysis/results.h5`.
 
 Do not add a dedicated `_fit_state` category or
 `_fit_state.schema_version`. Persisted fit state is detected from
-`_fit_result` and the related fit-state categories.
+`_fit_result`, `_fit_parameter`, `_fit_parameter_correlation`, and
+fit-output fields on `_minimizer.*`.
 
 ### Common fit-state categories
 
@@ -66,6 +67,15 @@ pre-fit scalar snapshots:
 - `fit_bounds_uncertainty_multiplier`
 - `start_value`
 - `start_uncertainty`
+- `posterior_best_sample_value`
+- `posterior_median`
+- `posterior_uncertainty`
+- `posterior_interval_68_low`
+- `posterior_interval_68_high`
+- `posterior_interval_95_low`
+- `posterior_interval_95_high`
+- `posterior_gelman_rubin`
+- `posterior_effective_sample_size_bulk`
 
 `_fit_result` stores the latest saved fit header:
 
@@ -80,15 +90,12 @@ pre-fit scalar snapshots:
 correlation summaries keyed by a persisted `id`. Only unique parameter
 pairs are stored.
 
-### Deterministic fit projection
+### Minimizer fit projection
 
-Deterministic fits persist `_deterministic_result` in addition to the
-common categories above.
+The active `_minimizer.*` category stores both user-selected solver
+inputs and fit-filled outputs. Deterministic minimizer classes store
+compact fit output counts:
 
-`_deterministic_result` stores compact optimizer metadata and counts:
-
-- `optimizer_name`
-- `method_name`
 - `objective_name`
 - `objective_value`
 - `n_data_points`
@@ -97,60 +104,56 @@ common categories above.
 - `degrees_of_freedom`
 - `covariance_available`
 - `correlation_available`
+- `runtime_seconds`
+- `iterations_performed`
+- `exit_reason`
 
 Do not persist a `_deterministic_parameter_result` category. Final
 deterministic parameter values and uncertainties already persist in the
 model CIF files, and restored deterministic ordering comes from
 `_fit_parameter`.
 
-### Bayesian fit projection
-
-Bayesian fits persist these additional categories:
-
-- `_bayesian_result`
-- `_bayesian_sampler`
-- `_bayesian_convergence`
-- `_bayesian_parameter_posterior`
-- `_bayesian_distribution_cache`
-- `_bayesian_pair_cache`
-- `_bayesian_predictive_dataset`
-
-`_bayesian_result` stores the saved Bayesian header and sidecar flags,
-including `sidecar_file`, `has_posterior_samples`,
-`has_distribution_cache`, `has_pair_cache`, and
-`has_posterior_predictive`.
-
-`_bayesian_sampler` stores the resolved sampler settings used for the
-run. `parallel` persists the resolved non-negative worker count as an
-integer.
-
-`_bayesian_convergence` stores convergence metadata and posterior array
-shape counts.
-
-`_bayesian_parameter_posterior` stores one summary row per sampled
-parameter, including credible intervals, uncertainty, ESS, and R-hat.
-Its row order defines the saved posterior parameter order.
-
-`_bayesian_distribution_cache`, `_bayesian_pair_cache`, and
-`_bayesian_predictive_dataset` store manifest rows for plot-ready
-posterior caches. Distribution and predictive caches are persisted for
-any Bayesian fit with posterior samples, including single-parameter
-fits. Pair caches and posterior correlation summaries are only persisted
-when more than one parameter was sampled.
-
-`parameter.posterior` is not part of this accepted design. This ADR
-persists analysis-level posterior summaries and caches only. Any future
-parameter-level posterior API remains a separate decision.
-
-### Bayesian sidecar
-
-Persist large Bayesian arrays in `analysis/results.h5` using `h5py`.
-This includes canonical posterior arrays and any saved distribution,
-pair, and predictive cache arrays referenced by the CIF manifests.
-
-The persisted `sidecar_file` value is a local file name only. It must
-resolve to a basename inside the project `analysis/` directory. Absolute
-paths and traversal paths are rejected and fall back to `results.h5`.
+Bayesian minimizer classes store sampler inputs and fit outputs under
+`_minimizer.*`, including:
+
+- `sampling_steps`
+- `burn_in_steps`
+- `thinning_interval`
+- `population_size`
+- `parallel_workers`
+- `initialization_method`
+- `random_seed`
+- `runtime_seconds`
+- `point_estimate_name`
+- `sampler_completed`
+- `credible_interval_inner`
+- `credible_interval_outer`
+- `acceptance_rate_mean`
+- `gelman_rubin_max`
+- `effective_sample_size_min`
+- `best_log_posterior`
+
+Bayesian per-parameter posterior summaries are stored on the
+corresponding `_fit_parameter` rows. Their row order defines the saved
+posterior parameter order.
+
+`FitResults.optimizer_name` and `FitResults.method_name` are restored
+from the active minimizer category class instead of being persisted as
+independent CIF fields. Each concrete minimizer category declares a
+class-level `_engine_metadata: ClassVar[dict[str, str]]` containing
+those two display values. This keeps the persisted projection to the
+user-selected `_minimizer.type` and removes duplicated deterministic
+metadata from `_minimizer.*`.
+
+### Posterior sidecar
+
+Persist large posterior arrays in `analysis/results.h5` using `h5py`.
+This includes canonical posterior arrays and saved distribution, pair,
+and predictive cache arrays. The HDF5 file is self-describing; no CIF
+manifest rows or sidecar filename tags are persisted.
+
+The sidecar filename is fixed to `results.h5` inside the project
+`analysis/` directory.
 
 If the sidecar is missing on load, summary rows in
 `analysis/analysis.cif` still restore fit tables and metadata. Features
@@ -168,9 +171,9 @@ Load order is:
 
 1. standard analysis configuration
 2. common fit-state categories
-3. deterministic or Bayesian fit-specific categories according to
-   `_fit_result.result_kind`
-4. Bayesian sidecar arrays when a Bayesian sidecar is expected
+3. `_minimizer.*` fit-output fields according to the active
+   `_minimizer.type`
+4. posterior sidecar arrays when a Bayesian result is expected
 
 Persist backend runtime objects, optimizer instances, and raw driver
 payloads nowhere in this design.
@@ -186,7 +189,8 @@ values remain in the model CIF files instead of being duplicated in a
 second deterministic per-parameter result loop.
 
 Bayesian persistence spans CIF metadata and an HDF5 sidecar, so save and
-load must validate consistency between manifest rows and bulk datasets.
+load must validate consistency between `_fit_parameter` rows and bulk
+datasets.
 
 The accepted runtime fit-results ADR should now be read as runtime-only
 except where this narrower projection explicitly persists fit-state

docs/dev/adrs/accepted/category-owner-sections.md

@@ -79,17 +79,19 @@ Project-level configuration follows the same pattern via a private
 Its current children are:
 
 - `ProjectInfo`
-- `Rendering`
+- `Chart`
+- `Table`
 
 The public API stays flat and user-facing:
 
 - `project.info`
-- `project.rendering`
+- `project.chart`
+- `project.table`
 
 Saved `project.cif` remains a section file without a `data_` header. It
-serializes the `_project.*` metadata category and the `_rendering.*`
-configuration category without pretending that the project config is a
-real datablock.
+serializes the `_project.*` metadata category plus the `_chart.*` and
+`_table.*` configuration categories without pretending that the project
+config is a real datablock.
 
 ### 4. CIF serialization is split by responsibility
 

docs/dev/adrs/accepted/display-ux.md

@@ -42,23 +42,22 @@ defaults.
 ## Decision
 
 Use `project.display` as the user-facing facade for display actions.
-Move serialized renderer settings out of that facade and into a separate
-project category named `project.rendering`.
+Move serialized renderer settings out of that facade and into separate
+project categories named `project.chart` and `project.table`.
 
 Renderer settings:
 
 ```python
-project.rendering.chart_engine = 'plotly'
-project.rendering.table_engine = 'pandas'
-project.rendering.show_chart_engines()
-project.rendering.show_table_engines()
-project.rendering.show_config()
+project.chart.type = 'plotly'
+project.table.type = 'pandas'
+project.chart.show_supported()
+project.table.show_supported()
 ```
 
 CIF names:
 
-- `_rendering.chart_engine`
-- `_rendering.table_engine`
+- `_chart.type`
+- `_table.type`
 
 No legacy loader is required for `_display.plotter_type` or
 `_display.tabler_type`. The project is in beta, so this cleanup may