Skip to content

[Scoped] Remove no longer needed vendor patch for VisibilityRequiredFixer #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 2 commits into from
Aug 14, 2025
Merged

[Scoped] Remove no longer needed vendor patch for VisibilityRequiredFixer #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0499ae
[Scoped] Remove no longer needed vendor patch for VisibilityRequiredF…
samsonasik Aug 14, 2025
7a215f7
re-run rector
samsonasik Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"phpstan/phpstan-phpunit": "^2.0.7",
"phpstan/phpstan-webmozart-assert": "^2.0",
"phpunit/phpunit": "^11.5.27",
"rector/rector": "^2.1.2",
"rector/rector": "^2.1.3",
"rector/type-perfect": "^2.1.0",
"symplify/phpstan-extensions": "^12.0.1",
"symplify/vendor-patches": "^11.5",
Expand Down Expand Up @@ -89,9 +89,6 @@
},
"extra": {
"patches": {
"friendsofphp/php-cs-fixer": [
"patches/friendsofphp-php-cs-fixer-src-fixer-classnotation-visibilityrequiredfixer-php.patch"
],
"illuminate/container": [
"patches/illuminate-container-container-php.patch"
],
Expand Down
14 changes: 0 additions & 14 deletions patches/friendsofphp-php-cs-fixer-src-fixer-classnotation-visibilityrequiredfixer-php.patch
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions src/Console/Output/GitlabOutputFormatter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@
final readonly class GitlabOutputFormatter implements OutputFormatterInterface
{
public function __construct(
private readonly EasyCodingStandardStyle $easyCodingStandardStyle,
private readonly ExitCodeResolver $exitCodeResolver,
private readonly DiffParser $diffParser,
private EasyCodingStandardStyle $easyCodingStandardStyle,
private ExitCodeResolver $exitCodeResolver,
private DiffParser $diffParser,
) {
}

Expand Down
4 changes: 0 additions & 4 deletions src/Utils/PrivatesAccessorHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,13 @@ final class PrivatesAccessorHelper
public static function getPropertyValue(object $object, string $propertyName): mixed
{
$reflectionProperty = new ReflectionProperty($object, $propertyName);
// this is needed for PHP 7.2 downgrade code
$reflectionProperty->setAccessible(true);

return $reflectionProperty->getValue($object);
}

public static function setPropertyValue(object $object, string $propertyName, mixed $value): void
{
$reflectionProperty = new ReflectionProperty($object, $propertyName);
// this is needed for PHP 7.2 downgrade code
$reflectionProperty->setAccessible(true);

$reflectionProperty->setValue($object, $value);
}
Expand Down